Re: [PATCH 1/4] UBI: Ensure that all fastmap work is done upon WL shutdown

[Tanya Brokhman <tlinder@codeaurora.org>]

On 10/2/2014 4:18 PM, Richard Weinberger wrote:
> Am 02.10.2014 15:05, schrieb Tanya Brokhman:
>>> +#ifdef CONFIG_MTD_UBI_FASTMAP
>>> +    flush_work(&ubi->fm_work);
>>
>> flush_work returns bool. It might be useful to print that value for debugging.
>
> Why would this be useful?
> The sole purpose of this flush is having a barrier.
> If flush_work() had to wait (returns true) for a pending work, fine.
> If where was no work (returns false) to wait for, also fine. :)

That's the thing - when debugging FS corruptions that occur on next 
boot, it's very useful to know exactly what happened on last power down. 
(Painful experience with other filesystems...)

We don't flush the fm on each write operation. We never flush on reads 
(and we will, as part of the read-disturb implementation. working on 
it), so it will be useful to know if fm was flashed at this point or wasn't.

>
> Thanks,
> //richard
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>

Thanks
Tanya Brokhman
-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation