Re: [PATCH v4 1/4] ubi-utils: ubidump: add ubifs-media

[hujianyang <hujianyang@huawei.com>]

On 2014/10/3 22:44, Artem Bityutskiy wrote:
> On Tue, 2014-09-30 at 12:06 +0800, hujianyang wrote:
>> @@ -0,0 +1,298 @@
>> +/*
>> + * Copyright (c) International Business Machines Corp., 2006
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
>> + * the GNU General Public License for more details.
>> + */
> 
> Hu,
> 
> probably I was not clear enough when commenting on the previous version
> of your patches.
> 
> Bu this is a copy of the kernel fs/ubifs/ubifs-media.h file.I see you
> stripped it down a little bit. But nevertheless, this is still a
> _copy_. 
> 
> You _absolutely_ must preserve the original license and copyright.
> 
> In this patch you just threw away original license and the copyright and
> put a different license and copyright. You cannot do this.
> 
> Please, preserve the original header from fs/ubifs/ubifs-media.h intact,
> as it is. Do not change it.
> 
> 
> .
> 

Oh, I'm sorry!

I used to think I've copied the whole copyright from fs/ubifs/ubifs-media.h.
Maybe I copied it from a wrong file.. Sorry for that, I should be more
careful.

I'll first moving "ALIGN" and "min_t" to common.h and then resend these
patches.