From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from h1446028.stratoserver.net ([85.214.92.142] helo=mail.ahsoftware.de) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xf3ch-00033V-Mf for linux-mtd@lists.infradead.org; Fri, 17 Oct 2014 09:15:00 +0000 Received: from eiche.ahsoftware (p4FC36386.dip0.t-ipconnect.de [79.195.99.134]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.ahsoftware.de (Postfix) with ESMTPSA id 393412C9C3CA for ; Fri, 17 Oct 2014 11:14:39 +0200 (CEST) Message-ID: <5440DDDA.90502@ahsoftware.de> Date: Fri, 17 Oct 2014 11:14:02 +0200 From: Alexander Holler MIME-Version: 1.0 To: linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/27] Fix common bug in most nand drivers not showing a device in sysfs References: <1401142372-14148-1-git-send-email-holler@ahsoftware.de> <543F678E.1030401@ahsoftware.de> In-Reply-To: <543F678E.1030401@ahsoftware.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am 16.10.2014 08:37, schrieb Alexander Holler: > Hello, > > I wonder if anyone else will fix this in a maintainer-approved style > which doesn't use these evil leftovers from C666 called functions. > > Or will the sysfs for most NAND drivers be knowingly broken forever? To explain that a bit more: 1. The reason I had to write 27 patches instead of just one is that such a function didn't exist. Therefor I've implemented one. 2. I was kind to write 27 patches to fix that silly bug. 3. I'm no fool and I will NOT write n * 21 patches in order to brutforce some maintainers prefered style. > > Regards, > > Alexander Holler > > Am 27.05.2014 00:12, schrieb Alexander Holler: >> A comment in mtdcore.c function add_mtd_device() which is called by >> mtd_device_parse_register() made me wonder: >> >> "Caller should have set dev.parent to match the physical device." >> >> In fact this is not done by most nand drivers. >> >> What follows is a series which fixes this. >> >> Tested: orion and omap2 >> Compile-Tested: atmel, gpio, fsmc, gpmi, plat, pxa3xx, s3c2410, sh_flctl, >> sharpsl, tmio, docg4, davinci, lpc32xx_mlc, lpc32xx_slc, mxc >> Not tested at all (only be view, patches 19-27): bcm47, fsl_elbc, >> fsl_upm, >> fsl_ifc, jz4740, mpc5121m, ndfc, txx9ndfmx, socrates >> >> The overall stat is >> >> 27 files changed, 36 insertions(+), 80 deletions(-) >> >> and it fixes 21 of these bugs. >> >> Regards, >> >> Alexander Holler >> >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> >