From: Richard Weinberger <richard@nod.at>
To: Andrew Murray <amurray@embedded-bits.co.uk>
Cc: linux-mtd@lists.infradead.org,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] mtd: ubi: Use UBI_METAONLY constraint for renames
Date: Mon, 20 Oct 2014 22:32:32 +0200 [thread overview]
Message-ID: <54457160.6040404@nod.at> (raw)
In-Reply-To: <CAPcvp5FhtmD3s+4goCCET5wxJtcvzoWkNcNg_PvCpBgprv5RJA@mail.gmail.com>
Am 20.10.2014 um 13:32 schrieb Andrew Murray:
> On 20 October 2014 12:06, Richard Weinberger <richard@nod.at> wrote:
>> Am 19.10.2014 um 22:26 schrieb Andrew Murray:
>>> Renaming a volume does not alter nor read volume data - thus the existing
>>> UBI_READWRITE constraint can be weakened. This patch provides a new
>>> UBI_METAONLY constraint and updates the UBI rename logic to use it.
>>>
>>> This change permits the rename of a mounted volume which enables support
>>> for additional methods of firmware upgrade - see discussion at
>>> https://patchwork.ozlabs.org/patch/398784
>>>
>>> This patch differs from that of the original discussion through the addition
>>> on an additional 'break' statement.
>>
>> Thanks for pointing out. I fat-fingered that.
>>
>>> Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>>> Tested-by: Andrew Murray <amurray@embedded-bits.co.uk>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> Signed-off-by: Andrew Murray <amurray@embedded-bits.co.uk>
>>
>> This is not a valid SoB chain. You are not the author of this patch
>> nor went it thought me. Please don't resend patches as your work.
>>
>
> Apologies that wasn't my intention - I got this wrong. I attempted to
> clearly attribute the author through the patch description and
> patchwork history and through the signed-off (I'll ask next time). I
> added my sign-off due to my (very trivial) addition.
No big deal. :)
Thanks,
//richard
prev parent reply other threads:[~2014-10-20 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 20:26 [PATCH] mtd: ubi: Use UBI_METAONLY constraint for renames Andrew Murray
2014-10-20 11:06 ` Richard Weinberger
2014-10-20 11:32 ` Andrew Murray
2014-10-20 20:32 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54457160.6040404@nod.at \
--to=richard@nod.at \
--cc=amurray@embedded-bits.co.uk \
--cc=dedekind1@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).