From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Roger Quadros <rogerq@ti.com>, Frans Klaver <frans.klaver@xsens.com>
Cc: linux-omap@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: omap: fix mtd devices not showing up
Date: Wed, 29 Oct 2014 10:34:57 -0300 [thread overview]
Message-ID: <5450ED01.4010305@vanguardiasur.com.ar> (raw)
In-Reply-To: <5450ECC1.10701@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
On 10/29/2014 10:33 AM, Roger Quadros wrote:
> On 10/29/2014 01:36 PM, Frans Klaver wrote:
>> On Tue, Oct 28, 2014 at 11:46:57AM +0200, Roger Quadros wrote:
>>> On 10/27/2014 04:34 PM, Frans Klaver wrote:
>>>> Since commit 6d178ef2fd5e ("mtd: nand: Move ELM driver and rename as
>>>> omap_elm"), I don't have any mtd devices present on my am335x. This
>>>> changes the link order of the omap_elm and omap2 objects, causing them
>>>> to probe in the wrong order.
>>>>
>>>> To fix this, make elm_config defer probing until the omap_elm driver is
>>>> actually loaded.
>>>>
>>>> Signed-off-by: Frans Klaver <frans.klaver@xsens.com>
>>>
>>> Acked-by: Roger Quadros <rogerq@ti.com>
>>
>> Thanks. How about Ezequiel's remark about doing both changes?
>
> I don't have any strong feeling for or against it. We shouldn't be depending on module load order anyways.
>
Agreed, feel free to disregard my suggestion.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-29 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 13:32 [PATCH typo-resend] mtd: omap: fix mtd devices not showing up Frans Klaver
2014-10-27 13:56 ` Roger Quadros
2014-10-27 14:01 ` Frans Klaver
2014-10-27 19:27 ` Ezequiel Garcia
2014-10-28 8:57 ` Frans Klaver
2014-10-28 8:58 ` Ezequiel Garcia
2014-10-27 14:34 ` [PATCH v2] " Frans Klaver
2014-10-28 9:46 ` Roger Quadros
2014-10-29 11:36 ` Frans Klaver
2014-10-29 13:33 ` Roger Quadros
2014-10-29 13:34 ` Ezequiel Garcia [this message]
2014-10-30 1:47 ` Brian Norris
2014-10-30 6:02 ` Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5450ED01.4010305@vanguardiasur.com.ar \
--to=ezequiel@vanguardiasur.com.ar \
--cc=computersforpeace@gmail.com \
--cc=frans.klaver@xsens.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox