From: Richard Weinberger <richard@nod.at>
To: dedekind1@gmail.com
Cc: axboe@fb.com, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-mtd@lists.infradead.org,
ezequiel.garcia@free-electrons.com, computersforpeace@gmail.com,
dwmw2@infradead.org
Subject: Re: [PATCH] UBI: Block: Add blk-mq support
Date: Fri, 07 Nov 2014 10:53:37 +0100 [thread overview]
Message-ID: <545C96A1.40304@nod.at> (raw)
In-Reply-To: <1415353596.958.302.camel@sauron.fi.intel.com>
Am 07.11.2014 um 10:46 schrieb Artem Bityutskiy:
> On Mon, 2014-11-03 at 09:23 +0100, Richard Weinberger wrote:
>> Am 03.11.2014 um 09:18 schrieb Christoph Hellwig:
>>> On Sun, Nov 02, 2014 at 02:00:55PM +0100, Richard Weinberger wrote:
>>>> +#define UBIBLOCK_SG_COUNT 64
>>>
>>>
>>> Can you document why you choose this number? The default nr_request
>>> for the old code would be 128.
>>
>> Is 64 a problem? Beside of the fact that I forgot to set blk_queue_max_segments().
>> I used this number because 128 seemed a bit high and my goal was to
>> keep the memory footprint small.
>> This is also why I've set tag_set.queue_depth to 64.
>
> The request was to document, so lets' document the choice.
Of course I'll document it. But so far I had no time to do a
v2 of this patch.
Thanks,
//richard
next prev parent reply other threads:[~2014-11-07 9:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 13:00 [PATCH] UBI: Block: Add blk-mq support Richard Weinberger
2014-11-02 21:52 ` Ezequiel Garcia
2014-11-02 22:21 ` Richard Weinberger
2014-11-02 22:27 ` Ezequiel Garcia
2014-11-02 22:49 ` Richard Weinberger
2014-11-03 1:20 ` Jens Axboe
2014-11-03 1:18 ` Jens Axboe
2014-11-03 5:03 ` Ming Lei
2014-11-03 13:58 ` Ezequiel Garcia
2014-11-03 18:22 ` Richard Weinberger
2014-11-03 8:18 ` Christoph Hellwig
2014-11-03 8:23 ` Richard Weinberger
2014-11-07 9:46 ` Artem Bityutskiy
2014-11-07 9:53 ` Richard Weinberger [this message]
2014-11-07 9:56 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545C96A1.40304@nod.at \
--to=richard@nod.at \
--cc=axboe@fb.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox