From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XvQhq-0002uL-45 for linux-mtd@lists.infradead.org; Mon, 01 Dec 2014 13:07:58 +0000 Received: by mail-pd0-f172.google.com with SMTP id y13so10960707pdi.3 for ; Mon, 01 Dec 2014 05:07:37 -0800 (PST) Message-ID: <547C6828.6010702@gmail.com> Date: Mon, 01 Dec 2014 21:07:52 +0800 From: Zhou Wang MIME-Version: 1.0 To: Brian Norris Subject: Re: [PATCH v4 2/2] mtd: hisilicon: add device tree binding documentation References: <1415105221-7732-1-git-send-email-wangzhou.bry@gmail.com> <1415105221-7732-3-git-send-email-wangzhou.bry@gmail.com> <20141130090106.GF3608@norris-Latitude-E6410> In-Reply-To: <20141130090106.GF3608@norris-Latitude-E6410> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, haojian.zhuang@gmail.com, wangzhou1@hisilicon.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, xuwei5@hisilicon.com, galak@codeaurora.org, caizhiyong@huawei.com, David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2014年11月30日 17:01, Brian Norris wrote: > One more thing: > > On Tue, Nov 04, 2014 at 08:47:01PM +0800, Zhou Wang wrote: >> diff --git a/Documentation/devicetree/bindings/mtd/hisi504-nand.txt b/Documentation/devicetree/bindings/mtd/hisi504-nand.txt >> new file mode 100644 >> index 0000000..c8b3988 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/hisi504-nand.txt >> @@ -0,0 +1,40 @@ >> +Hisilicon Hip04 Soc NAND controller DT binding >> + >> +Required properties: >> +- compatible: Should be "hisilicon,504-nfc". > > I notice you use "NFC" naming throughout. I know others have had > complaints about overloading the acronym NFC which sometimes means "Near > Field Communication", instead of the intended "NAND Flash Controller." > Is there any kind of naming convention within Hisilicon documentation > that insists on calling this NFC, or can we avoid that confusing name? > > If possible, I'd suggest "hisilicon,504-nand" as an alternative. > I think that is a good idear to call "hisilicon,504-nand", in fact, at the beginning, I also confused with the name "nfc". > Brian > Thanks, Zhou Wang