From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga03-in.huawei.com ([119.145.14.66]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y0myb-0006wh-5N for linux-mtd@lists.infradead.org; Tue, 16 Dec 2014 07:55:26 +0000 Message-ID: <548FE51D.60707@huawei.com> Date: Tue, 16 Dec 2014 15:54:05 +0800 From: hujianyang MIME-Version: 1.0 To: Artem Bityutskiy Subject: [PATCH] UBI: add ubi_err() to report the failure of leb read Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Richard Weinberger , linux-mtd List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , If an error occur while reading from PEBs, for example, an ECC error, ubi_io_read() will print some error messages. But it's not enough for debugging. These messages don't show the mapping info for a read from UBIFS layer. Although UBIFS will soon print its error messages after catching the return value from UBI layer, multi-path reading will confuse the relationship between LEBs and PEBs showed by these messages. This patch adds an ubi_err() to report reading errors in the function ubi_eba_read_leb(). The mapping info of LEB and PEB is showed by this error message. Signed-off-by: hujianyang --- drivers/mtd/ubi/eba.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index b698534..b4e69e1 100644 --- a/drivers/mtd/ubi/eba.c +++ b/drivers/mtd/ubi/eba.c @@ -477,6 +477,8 @@ out_free: ubi_free_vid_hdr(ubi, vid_hdr); out_unlock: leb_read_unlock(ubi, vol_id, lnum); + ubi_err(ubi, "err %d while reading %d bytes from offset %d of LEB %d:%d, PEB %d", + err, len, offset, vol_id, lnum, pnum); return err; } -- 1.6.0.2