public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gregungerer@westnet.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k <linux-m68k@lists.linux-m68k.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-mtd@lists.infradead.org,
	Alexander Shiyan <shc_work@mail.ru>
Subject: Re: m68k: io{read,write} accessors
Date: Thu, 29 Aug 2013 19:57:50 +0800 (WST)	[thread overview]
Message-ID: <549050543.4739751377777470469.JavaMail.root@zim-store05.web.westnet.com.au> (raw)
In-Reply-To: <CAMuHMdXdS5j==sOoj3WKkTsjzMwWHZDEhYMSXNDErpB82xT=+w@mail.gmail.com>

Hi Geert,

----- "Geert Uytterhoeven" <geert@linux-m68k.org> wrote:
> On Wed, Aug 28, 2013 at 8:36 PM, Brian Norris
> <computersforpeace@gmail.com> wrote:
> > It appears that m68k doesn't properly define the io{read,write}
> > functions. I get complaints like this from my compile testing:
> >
> > drivers/mtd/nand/nand_base.c: In function 'nand_write_buf':
> > drivers/mtd/nand/nand_base.c:216:2: error: implicit declaration of
> > function 'iowrite8_rep' [-Werror=implicit-function-declaration]
> > drivers/mtd/nand/nand_base.c: In function 'nand_read_buf':
> > drivers/mtd/nand/nand_base.c:231:2: error: implicit declaration of
> > function 'ioread8_rep' [-Werror=implicit-function-declaration]
> > drivers/mtd/nand/nand_base.c: In function 'nand_write_buf16':
> > drivers/mtd/nand/nand_base.c:247:2: error: implicit declaration of
> > function 'iowrite16_rep' [-Werror=implicit-function-declaration]
> > drivers/mtd/nand/nand_base.c: In function 'nand_read_buf16':
> > drivers/mtd/nand/nand_base.c:263:2: error: implicit declaration of
> > function 'ioread16_rep' [-Werror=implicit-function-declaration]
> 
> This is a nommu config?
> If CONFIG_MMU=y,  GENERIC_IOMAP=y and iowrite8_rep() is available.
> 
> Greg: is there any reason we can't use GENERIC_IOMAP=y for the nommu
> case too?

None at all. Thus this patch:

http://www.spinics.net/lists/linux-m68k/msg06224.html

I have it in the m68knommu git tree, for-next branch. I intend pushing
it for 3.12.

Regards
Greg

  parent reply	other threads:[~2013-08-29 11:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 18:36 m68k: io{read,write} accessors Brian Norris
2013-08-29  8:15 ` Geert Uytterhoeven
2013-08-29  9:09   ` Brian Norris
2013-08-29 11:57   ` Greg Ungerer [this message]
2013-08-29 12:07     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549050543.4739751377777470469.JavaMail.root@zim-store05.web.westnet.com.au \
    --to=gregungerer@westnet.com.au \
    --cc=computersforpeace@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox