Re: [PATCH v4] UBI: block: Continue creating ubiblocks after an initialization error

[Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>]

Hey Dan,

On 12/18/2014 08:33 PM, Dan Ehrenberg wrote:
> If one ubi volume is corrupted but another is not, it should be
> possible to initialize that ubiblock from a kernel commandline which
> includes both of them. This patch changes the error handling behavior
> in initializing ubiblock to ensure that all parameters are attempted
> even if one fails. If there is a failure, it is logged on dmesg.
> It also makes error messages more descriptive by including the
> name of the UBI volume that failed.
> 
> Tested: Formatted ubi volume /dev/ubi5_0 in a corrupt way and
> dev/ubi3_0 properly and included "ubi.block=5,0 ubi.block=3,0" on
> the kernel command line. At boot, I see the following in the console:
> [   21.082420] UBI error: ubiblock_create_from_param: block: can't open volume on ubi5_0, err=-19
> [   21.084268] UBI: ubiblock3_0 created from ubi3:0(rootfs)
> 
> Signed-off-by: Dan Ehrenberg <dehrenberg@chromium.org>
> ---
> Changes in v4:

I think you should re-send on top of linux-next. Commit
326087033108e7806e24974f2c8271f95cddaf3a has changed the way
user messages are printed.

Other than that, the patch looks good:

Acked-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

Thanks!
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar