From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <549D2A9D.50407@atmel.com> Date: Fri, 26 Dec 2014 17:30:05 +0800 From: Josh Wu MIME-Version: 1.0 To: Boris Brezillon , David Woodhouse , Brian Norris , , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Andrew Victor Subject: Re: [PATCH 2/4] mtd: nand: atmel: Update DT documentation after splitting NFC and NAND References: <1417732214-3292-1-git-send-email-boris.brezillon@free-electrons.com> <1417732214-3292-3-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1417732214-3292-3-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, Boris Thanks for the patch. You need to rebase on the top of current mtd-l2 git tree. As I had some change on the binding document. Best Regards, Josh Wu On 12/5/2014 6:30 AM, Boris Brezillon wrote: > The NAND and NFC (NAND Flash Controller) were linked together with a > parent <-> child relationship. > > This model has several drawbacks: > - it does not allow for multiple NAND chip handling while the controller > support multi-chip (even though the driver is not ready yet) > - it mixes NAND partitions and NFC nodes at the same level (which is a bit > disturbing) > - the introduction of the EBI bus implies defining NAND chips under the > EBI node, and the ranges available under the EBI node should be > restricted to EBI address space, while the NFC references several > registers outside of these EBI ranges. > > Move the NFC node outside of the NAND node, to get a more future-proof > model. > > Signed-off-by: Boris Brezillon > --- > .../devicetree/bindings/mtd/atmel-nand.txt | 46 ++++++++++++---------- > 1 file changed, 26 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > index 6edc3b6..8896850 100644 > --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt > +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > @@ -30,15 +30,19 @@ Optional properties: > sector size 1024. > - nand-bus-width : 8 or 16 bus width if not present 8 > - nand-on-flash-bbt: boolean to enable on flash bbt option if not present false > -- Nand Flash Controller(NFC) is a slave driver under Atmel nand flash > - - Required properties: > - - compatible : "atmel,sama5d3-nfc". > - - reg : should specify the address and size used for NFC command registers, > - NFC registers and NFC Sram. NFC Sram address and size can be absent > - if don't want to use it. > - - clocks: phandle to the peripheral clock > - - Optional properties: > - - atmel,write-by-sram: boolean to enable NFC write by sram. > +- atmel,nfc: phandle referencing the NAND Flash Controller, if available. > + > +The NAND Flash Controller (NFC) is an advanced NAND controller and should be > +used in conjunction with the NAND flash device. > +Required properties: > + - compatible : "atmel,sama5d3-nfc". > + - reg : should specify the address and size used for NFC command registers, > + NFC registers and NFC Sram. NFC Sram address and size can be absent > + if you don't want to use it. > + - clocks: phandle to the peripheral clock > + > +Optional properties: > + - atmel,write-by-sram: boolean to enable NFC write by sram. > > Examples: > nand0: nand@40000000,0 { > @@ -89,21 +93,23 @@ nand0: nand@40000000 { > }; > > /* for NFC supported chips */ > +nfc: nfc@70000000 { > + compatible = "atmel,sama5d3-nfc"; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&hsmc_clk> > + reg = < > + 0x70000000 0x10000000 /* NFC Command Registers */ > + 0xffffc000 0x00000070 /* NFC HSMC regs */ > + 0x00200000 0x00100000 /* NFC SRAM banks */ > + >; > +}; > + > nand0: nand@40000000 { > compatible = "atmel,at91rm9200-nand"; > #address-cells = <1>; > #size-cells = <1>; > ranges; > + atmel,nfc = <&nfc>; > ... > - nfc@70000000 { > - compatible = "atmel,sama5d3-nfc"; > - #address-cells = <1>; > - #size-cells = <1>; > - clocks = <&hsmc_clk> > - reg = < > - 0x70000000 0x10000000 /* NFC Command Registers */ > - 0xffffc000 0x00000070 /* NFC HSMC regs */ > - 0x00200000 0x00100000 /* NFC SRAM banks */ > - >; > - }; > };