From: Richard Weinberger <richard@nod.at>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>, dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] UBI: Fastmap: Care about the protection queue
Date: Fri, 09 Jan 2015 22:31:09 +0100 [thread overview]
Message-ID: <54B0489D.1050905@nod.at> (raw)
In-Reply-To: <54B046BC.8060802@vanguardiasur.com.ar>
Am 09.01.2015 um 22:23 schrieb Ezequiel Garcia:
> On 11/24/2014 10:20 AM, Richard Weinberger wrote:
>> Fastmap can miss a PEB if it is in the protection queue
>> and not jet in the used tree.
>
> s/jet/yet
>
>> Treat every protected PEB as used.
>>
>
> I'm wondering if we can have a detailed description of the issues this
> commit fixes (if any?). In other words, what's the result of *not*
> having the patch?
Without this patch fastmap can miss one PEB.
As consequence of this during attach the fastmap self-check
will detect this inconsistency and will fall back to a full scan.
If you try to attach using a custom fastmap implementation (found in
bootloaders) which do often not have sophisticated self-checks you'll
face a serious data corruption or if you're lucky UBI will crash.
Now clearer? :-)
Thanks,
//richard
next prev parent reply other threads:[~2015-01-09 21:31 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 13:20 Fastmap update v2 (pile 1) Richard Weinberger
2014-11-24 13:20 ` [PATCH 1/6] UBI: Fastmap: Care about the protection queue Richard Weinberger
2014-11-27 14:54 ` Artem Bityutskiy
2015-01-09 21:23 ` Ezequiel Garcia
2015-01-09 21:31 ` Richard Weinberger [this message]
2015-01-09 21:34 ` Ezequiel Garcia
2014-11-24 13:20 ` [PATCH 2/6] UBI: Fastmap: Ensure that only one fastmap work is scheduled Richard Weinberger
2014-11-27 15:27 ` Artem Bityutskiy
2014-11-27 16:13 ` Richard Weinberger
2014-11-27 16:35 ` Artem Bityutskiy
2014-11-27 16:39 ` Richard Weinberger
2014-11-27 16:49 ` Artem Bityutskiy
2014-12-04 16:14 ` Tanya Brokhman
2014-12-17 13:51 ` Guido Martínez
2014-11-24 13:20 ` [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown Richard Weinberger
2014-11-27 15:38 ` Artem Bityutskiy
2014-11-27 16:08 ` Richard Weinberger
2014-11-27 16:29 ` Artem Bityutskiy
2014-11-27 16:35 ` Richard Weinberger
2014-11-27 16:47 ` Artem Bityutskiy
2014-11-28 9:53 ` Richard Weinberger
2014-12-04 16:44 ` Tanya Brokhman
2014-12-04 17:21 ` Richard Weinberger
2014-12-17 14:26 ` Guido Martínez
2015-01-09 21:32 ` Ezequiel Garcia
2015-01-09 21:37 ` Richard Weinberger
2015-01-09 21:39 ` Ezequiel Garcia
2014-11-24 13:20 ` [PATCH 4/6] UBI: Fastmap: Fix races in ubi_wl_get_peb() Richard Weinberger
2014-12-05 13:09 ` Tanya Brokhman
2014-12-05 13:20 ` Richard Weinberger
2014-12-05 16:54 ` Tanya Brokhman
2014-12-05 21:08 ` Richard Weinberger
2014-12-07 7:36 ` Tanya Brokhman
2014-12-07 9:45 ` Richard Weinberger
2014-11-24 13:20 ` [PATCH 5/6] UBI: Split __wl_get_peb() Richard Weinberger
2014-12-05 17:41 ` Tanya Brokhman
2014-12-05 21:02 ` Richard Weinberger
2014-12-17 15:03 ` Guido Martínez
2014-11-24 13:20 ` [PATCH 6/6] UBI: Fastmap: Make ubi_refill_pools() fair Richard Weinberger
2014-12-05 17:55 ` Tanya Brokhman
2014-12-05 20:56 ` Richard Weinberger
2014-12-07 7:55 ` Tanya Brokhman
2014-12-07 9:49 ` Richard Weinberger
2014-12-17 15:48 ` Guido Martínez
2014-11-27 14:53 ` Fastmap update v2 (pile 1) Artem Bityutskiy
2014-11-27 14:59 ` Richard Weinberger
2014-12-10 8:21 ` Richard Weinberger
2015-01-05 10:37 ` Richard Weinberger
2015-01-09 21:38 ` Ezequiel Garcia
2015-01-09 21:55 ` Richard Weinberger
2015-01-09 22:09 ` Ezequiel Garcia
2015-01-09 22:20 ` Richard Weinberger
2015-03-29 10:46 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B0489D.1050905@nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).