From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.codeaurora.org ([198.145.11.231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YCEst-00083d-9k for linux-mtd@lists.infradead.org; Fri, 16 Jan 2015 21:56:51 +0000 Message-ID: <54B9890C.2080506@codeaurora.org> Date: Fri, 16 Jan 2015 13:56:28 -0800 From: Stephen Boyd MIME-Version: 1.0 To: Archit Taneja , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/5] clk: qcom: Add EBI2 clocks for IPQ806x References: <1421419702-17812-1-git-send-email-architt@codeaurora.org> <1421419702-17812-2-git-send-email-architt@codeaurora.org> In-Reply-To: <1421419702-17812-2-git-send-email-architt@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: galak@codeaurora.org, linux-kernel@vger.kernel.org, agross@codeaurora.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/16/2015 06:48 AM, Archit Taneja wrote: > The NAND controller within EBI2 requires EBI2_CLK and EBI2_ALWAYS_ON_CLK clocks. > Create structs for these clocks so that they can be used by the NAND controller > driver. Add an entry for EBI2_AON_CLK in the gcc-ipq806x DT binding document. > > Cc: Stephen Boyd > Signed-off-by: Archit Taneja Looks ok. I couldn't find this used in the downstream sources though. Can you point me to it? I'm mostly worried that this is a shared resource that never should be turned off, so exposing it to drivers may not be the right idea. > +static struct clk_branch ebi2_aon_clk = { > + .hwcg_reg = 0x3b00, > + .hwcg_bit = 6, > + .halt_reg = 0x2fcc, > + .halt_bit = 0, > + .clkr = { > + .enable_reg = 0x3b00, > + .enable_mask = BIT(8), > + .hw.init = &(struct clk_init_data){ > + .name = "ebi2_always_on_clk", > Can this be ebi2_aon_clk to match the macro? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project