From: Josh Wu <josh.wu@atmel.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Rob Herring <robh+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-mtd@lists.infradead.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: at91: sama5d4: dts: change the nand compatible string
Date: Wed, 21 Jan 2015 11:55:59 +0800 [thread overview]
Message-ID: <54BF234F.9060202@atmel.com> (raw)
In-Reply-To: <20150120204915.GS9759@ld-irv-0074>
Hi, Brain
On 1/21/2015 4:49 AM, Brian Norris wrote:
> On Mon, Jan 19, 2015 at 04:33:07PM +0800, Josh Wu wrote:
>> As we introduce a new "atmel,sama5d4-nand" compatible string for sama5d4,
>> so we need to apply it for sama5d4 chip.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>> ---
>>
>> arch/arm/boot/dts/sama5d4.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
>> index 1b0f30c..02d67c2 100644
>> --- a/arch/arm/boot/dts/sama5d4.dtsi
>> +++ b/arch/arm/boot/dts/sama5d4.dtsi
>> @@ -267,7 +267,7 @@
>> };
>>
>> nand0: nand@80000000 {
>> - compatible = "atmel,at91rm9200-nand";
>> + compatible = "atmel,sama5d4-nand";
> Wouldn't it make sense to include both compatible strings, so that old
> kernels can still bind to it?
yes, that make sense. I'll add it.
> The newer IP only adds a new ECC feature,
> but the driver still can work fine without handling it, right?
so far it works fine without this new feature. But I am not 100% sure
for this :-)
Best Regards,
Josh Wu
>
>> #address-cells = <1>;
>> #size-cells = <1>;
>> ranges;
> Brian
next prev parent reply other threads:[~2015-01-21 3:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 8:33 [PATCH 1/2] mtd: atmel_nand: introduce a new compatible string for sama5d4 chip Josh Wu
2015-01-19 8:33 ` [PATCH 2/2] ARM: at91: sama5d4: dts: change the nand compatible string Josh Wu
2015-01-20 20:49 ` Brian Norris
2015-01-21 3:55 ` Josh Wu [this message]
2015-01-22 10:41 ` [PATCH v2] " Josh Wu
2015-01-22 11:01 ` Nicolas Ferre
2015-01-26 15:07 ` Nicolas Ferre
2015-01-26 17:12 ` Brian Norris
2015-01-20 20:47 ` [PATCH 1/2] mtd: atmel_nand: introduce a new compatible string for sama5d4 chip Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BF234F.9060202@atmel.com \
--to=josh.wu@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).