From: Richard Weinberger <richard@nod.at>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Richard Weinberger <richard.weinberger@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: Expose partition offset to the drivers
Date: Mon, 02 Feb 2015 20:37:31 +0100 [thread overview]
Message-ID: <54CFD1FB.5030208@nod.at> (raw)
In-Reply-To: <CAPybu_3D1cG3YpB8Y6h+UX2V7NN5Z9+BmDABt4J=6++KS=E8PQ@mail.gmail.com>
Hi!
Am 02.02.2015 um 20:33 schrieb Ricardo Ribalda Delgado:
> Hello
>
> On Mon, Feb 2, 2015 at 8:17 PM, Richard Weinberger
> <richard.weinberger@gmail.com> wrote:
>> On Mon, Feb 2, 2015 at 5:22 PM, Ricardo Ribalda Delgado
>>
>> Can you please also send a patch which shows the usage of this new function
>> by a driver?
>
> It is currently out of tree, but here you can see the relevant code:
>
> mtd_offset=mtd_get_device_offset(mtd);
> put_mtd_device(mtd);
> if (do_jmp){
> ret=qt5023_hwicap_reset(head,mtd_offset);
> if (ret){
> dev_err(&head->pci_dev->dev,"error: Failed to jump to new bitfile\n");
> vfree(buffer);
> release_firmware(firmware);
> return -EIO;
> }
> qt5023_spi_restart(head);
> }
Hmm, will we ever need the new function for in-tree drivers?
In general we add new functions only if they have an in-tree user
for it.
Thanks,
//richard
next prev parent reply other threads:[~2015-02-02 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 16:22 [PATCH] mtd: Expose partition offset to the drivers Ricardo Ribalda Delgado
2015-02-02 19:17 ` Richard Weinberger
2015-02-02 19:33 ` Ricardo Ribalda Delgado
2015-02-02 19:37 ` Richard Weinberger [this message]
2015-02-02 19:51 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CFD1FB.5030208@nod.at \
--to=richard@nod.at \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ricardo.ribalda@gmail.com \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox