From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <54FCAF6C.7010902@free-electrons.com> Date: Sun, 08 Mar 2015 17:22:04 -0300 From: Ezequiel Garcia MIME-Version: 1.0 To: Robert Jarzmik Subject: Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller References: <1425555085-29531-1-git-send-email-antoine.tenart@free-electrons.com> <1425555085-29531-6-git-send-email-antoine.tenart@free-electrons.com> <54FA6DFC.1070904@free-electrons.com> <87oao3xvh8.fsf@free.fr> In-Reply-To: <87oao3xvh8.fsf@free.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: thomas.petazzoni@free-electrons.com, boris.brezillon@free-electrons.com, Antoine Tenart , linux-kernel@vger.kernel.org, zmxu@marvell.com, linux-mtd@lists.infradead.org, jszhang@marvell.com, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/08/2015 02:14 PM, Robert Jarzmik wrote: > Ezequiel Garcia writes: > >> Hi Antoine, >> >> On 03/05/2015 08:31 AM, Antoine Tenart wrote: >> [..] >>> + >>> +static struct pxa3xx_nand_flash berlin_builtin_flash_types[] = { >>> +{ "4GiB 8-bit", 0xd7ec, 128, 8192, 8, 8, 4096 }, >>> +{ }, >> >> IMHO, supporting a specific flash shouldn't be part of this patch. >> >> In any case, why do you need this? If you can share the details about >> this device, it would be interesting for me to take a look. >> >> This driver's open-coded, legacy-style flash detection is nasty, and the >> only reason I've kept it is to avoid breaking some wacky user with some >> old board. In fact, maybe we can just kill it so nobody thinks it's sane. > > I think you'll kill the zylonite board, and I'll nack it if that's the case. At > least that's what happened when I tried to use onfi default values last time in > barebox development. > > I can test your changes, but if the specific zylonite nand (ie. nand id 0xba20, > ie. pxa310 embedded flash) gets broken, I'm against the removal of the legacy > timings removal. > I'm not speaking of any timing params here, but about the flash identification. Which flash do you have there? -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com