public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Dan Ehrenberg <dehrenberg@chromium.org>,
	computersforpeace@gmail.com, linux-mtd@lists.infradead.org
Cc: Richard Weinberger <richard@nod.at>,
	gwendal@chromium.org, Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] UBI: block: Add option for dynamic minor number
Date: Mon, 16 Mar 2015 20:12:34 -0300	[thread overview]
Message-ID: <55076362.7040705@vanguardiasur.com.ar> (raw)
In-Reply-To: <1426539315-17392-1-git-send-email-dehrenberg@chromium.org>

(Adding UBI maintainers)

On 03/16/2015 05:55 PM, Dan Ehrenberg wrote:
> This patch adds a new config option, MTD_UBI_BLOCK_DYNAMIC_MINOR, which
> makes minor numbers dynamically allocated for ubiblock devices, starting
> at 0.
> 
> From the new Kconfig:
>     This option makes ubiblock devices have minor numbers beginning from
>     0, allocated dynamically independently of the ubi device/volume
>     number. For users who don't refer to an ubiblock device directly by
>     the major:minor number (e.g., with udev and/or devtmpfs), this option
>     is useful if the device number is rather high (>1) and when executing
>     on a 32-bit platform without LFS enabled in all userspace binaries.
> 

Hm, I'm wondering if there are any users relying on a specific minor.

I'm not fond of the new option, and I'm not fond of the ifdefs you bring
in. Can't we just change minors to be dynamic?
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

  reply	other threads:[~2015-03-16 23:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 20:55 [PATCH] UBI: block: Add option for dynamic minor number Dan Ehrenberg
2015-03-16 23:12 ` Ezequiel Garcia [this message]
2015-03-16 23:21   ` Nicholas Krause
2015-03-16 23:56   ` Daniel Ehrenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55076362.7040705@vanguardiasur.com.ar \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dehrenberg@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox