From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YXecv-0002qE-Qb for linux-mtd@lists.infradead.org; Mon, 16 Mar 2015 23:40:54 +0000 Message-ID: <550769DD.2020208@broadcom.com> Date: Mon, 16 Mar 2015 16:40:13 -0700 From: Scott Branden MIME-Version: 1.0 To: Brian Norris Subject: Re: [PATCH 2/3] Documentation: devicetree: add binding doc for Broadcom NAND controller References: <1425691129-1150-1-git-send-email-computersforpeace@gmail.com> <1425691129-1150-3-git-send-email-computersforpeace@gmail.com> <55076247.4070104@broadcom.com> <20150316233706.GL32500@ld-irv-0074> In-Reply-To: <20150316233706.GL32500@ld-irv-0074> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, Florian Fainelli , Kevin Cernekee , Corneliu Doban , Ray Jui , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-kernel@vger.kernel.org, Jonathan Richardson , Anatol Pomazao , bcm-kernel-feedback-list@broadcom.com, linux-mtd@lists.infradead.org, Dmitry Torokhov List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 15-03-16 04:37 PM, Brian Norris wrote: > On Mon, Mar 16, 2015 at 04:07:51PM -0700, Scott Branden wrote: >> On 15-03-06 05:18 PM, Brian Norris wrote: >>> Signed-off-by: Brian Norris >>> --- >>> .../devicetree/bindings/mtd/brcmstb_nand.txt | 109 +++++++++++++++++++++ >>> 1 file changed, 109 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/mtd/brcmstb_nand.txt >>> >>> diff --git a/Documentation/devicetree/bindings/mtd/brcmstb_nand.txt b/Documentation/devicetree/bindings/mtd/brcmstb_nand.txt >>> new file mode 100644 >>> index 000000000000..933d44943cbb >>> --- /dev/null >> >> Could you change the binding document with the vendor prefix to >> match all the other drivers we have been submitting? ie. >> "brcm,brcmnand.txt" > > $ find Documentation/devicetree/ -name 'broadcom*' > Documentation/devicetree/bindings/net/broadcom-systemport.txt > Documentation/devicetree/bindings/net/broadcom-bcm87xx.txt > Documentation/devicetree/bindings/net/broadcom-mdio-unimac.txt > Documentation/devicetree/bindings/net/broadcom-bcmgenet.txt > Documentation/devicetree/bindings/net/broadcom-sf2.txt > > $ find Documentation/devicetree/ -name 'brcm[^,]*' > Documentation/devicetree/bindings/arm/brcm-brcmstb.txt > > $ find Documentation/devicetree/ -name 'brcm,*' > Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt > Documentation/devicetree/bindings/interrupt-controller/brcm,l2-intc.txt > Documentation/devicetree/bindings/interrupt-controller/brcm,bcm7120-l2-intc.txt > Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt > Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt > Documentation/devicetree/bindings/i2c/brcm,bcm2835-i2c.txt > Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.txt > Documentation/devicetree/bindings/rng/brcm,bcm2835.txt > Documentation/devicetree/bindings/pinctrl/brcm,bcm2835-gpio.txt > Documentation/devicetree/bindings/pinctrl/brcm,bcm11351-pinctrl.txt > Documentation/devicetree/bindings/bus/brcm,gisb-arb.txt > Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt > Documentation/devicetree/bindings/arm/bcm/brcm,bcm11351-cpu-method > Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhci.txt > Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt > > $ find Documentation/devicetree/bindings -name '*.txt' | grep -v ','| wc -l > 1227 > $ find Documentation/devicetree/bindings -name '*.txt' | grep ','| wc -l > 352 > > So, what's the standard? Company prefix? Long name? Commas? Hyphens? The problem with devicetree binding is there is no standard for much of anything. Some others use the vendor prefix for all their binding documentation. We can try to do the same? > > Brian >