From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Boaz Harrosh <boaz@plexistor.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: codalist@TELEMANN.coda.cs.cmu.edu,
jfs-discussion@lists.sourceforge.net,
linux-ntfs-dev@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [Jfs-discussion] [PATCH] fs: cleanup slight list_entry abuse
Date: Thu, 19 Mar 2015 11:55:21 -0500 [thread overview]
Message-ID: <550AFF79.1030105@oracle.com> (raw)
In-Reply-To: <550AF51C.9000600@plexistor.com>
On 03/19/2015 11:11 AM, Boaz Harrosh wrote:
> On 03/19/2015 01:28 PM, Rasmus Villemoes wrote:
>> list_entry is just a wrapper for container_of, but it is arguably
>> wrong (and slightly confusing) to use it when the pointed-to struct
>> member is not a struct list_head. Use container_of directly instead.
>>
>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>> ---
>> Most of these predate git. If I'm the only one who has been confused
>> by this in 10 years, maybe it's not worth the churn.
>>
>
> No you are not alone here. I have seen this once as well but did not have
> the gumption to send a fix. (The sysv.h one)
>
> I totally agree with this patch. (So many of them, bread crumbs of copy/paste
> for you ;0)
I'm sure that was the case with jfs.
>
> Reviewed-by: Boaz Harrosh <boaz@plexistor.com>
Acked-by: Dave Kleikamp <dave.kleikamp@oracle.com>
next prev parent reply other threads:[~2015-03-19 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 11:28 [PATCH] fs: cleanup slight list_entry abuse Rasmus Villemoes
2015-03-19 16:11 ` Boaz Harrosh
2015-03-19 16:55 ` Dave Kleikamp [this message]
2015-05-12 12:13 ` [Jfs-discussion] " Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550AFF79.1030105@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=boaz@plexistor.com \
--cc=codalist@TELEMANN.coda.cs.cmu.edu \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux@rasmusvillemoes.dk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).