From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.thorsis.com ([213.211.200.15]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dc4Dq-0004Pk-U7 for linux-mtd@lists.infradead.org; Mon, 31 Jul 2017 06:30:37 +0000 From: Alexander Dahl To: Boris Brezillon Cc: linux-mtd@lists.infradead.org, Richard Weinberger Subject: Re: mtd: nand: atmel: probe of Spansion S34ML02G1 fails Date: Mon, 31 Jul 2017 08:29:35 +0200 Message-ID: <55614391.xdWgSdKuKi@ada> In-Reply-To: <20170728211301.10d25227@bbrezillon> References: <5326598.QgYTQxcFMR@ada> <2274647.ublHvqEhgW@ada> <20170728211301.10d25227@bbrezillon> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello Boris, Am Freitag, 28. Juli 2017, 21:13:01 schrieb Boris Brezillon: > Can you try with the following patch? Timings are expressed in > picoseconds and this test was testing against a value expressed in > nanoseconds. >=20 > BTW, did you try to comment the line I pointed out yesterday? I'd lik= e > to be sure this is a timing issue. Now I did, see my other mail. > --->8--- > diff --git a/drivers/mtd/nand/atmel/nand-controller.c > b/drivers/mtd/nand/atmel/nand-controller.c index > d922a88e407f..2c8baa0c2c4e 100644 > --- a/drivers/mtd/nand/atmel/nand-controller.c > +++ b/drivers/mtd/nand/atmel/nand-controller.c > @@ -1201,7 +1201,7 @@ static int atmel_smc_nand_prepare_smcconf(struc= t > atmel_nand *nand, * tRC < 30ns implies EDO mode. This controller does= > not support this * mode. > */ > - if (conf->timings.sdr.tRC_min < 30) > + if (conf->timings.sdr.tRC_min < 30000) > return -ENOTSUPP; >=20 > atmel_smc_cs_conf_init(smcconf); This gives me the following debug output (with my own debug messages=20= from the patch in one mail from last week, with an additional dump of=20= the values read from onfi page): atmel-nand-controller 10000000.ebi:nand-controller: atmel_smc_nand_setu= p_data_interface(csline: 0, type: 0) atmel-nand-controller 10000000.ebi:nand-controller: tBERS_max: 0, tCCS_= min: 500000, tPROG_max: 0, tR_max: 200000000 atmel-nand-controller 10000000.ebi:nand-controller: tALH_min: 20000, tA= DL_min: 400000, tALS_min: 50000, tAR_min: 25000 atmel-nand-controller 10000000.ebi:nand-controller: tCEA_max: 100000, t= CEH_min: 20000, tCH_min: 20000, tCHZ_max: 100000 atmel-nand-controller 10000000.ebi:nand-controller: tCLH_min: 20000, tC= LR_min: 20000, tCLS_min: 50000, tCOH_min: 0 atmel-nand-controller 10000000.ebi:nand-controller: tCS_min: 70000, tDH= _min: 20000, tDS_min: 40000, tFEAT_max: 1000000 atmel-nand-controller 10000000.ebi:nand-controller: tIR_min: 10000, tIT= C_max: 1000000, tRC_min: 100000, tREA_max: 40000 atmel-nand-controller 10000000.ebi:nand-controller: tREH_min: 30000, tR= HOH_min: 0, tRHW_min: 200000, tRHZ_max: 200000 atmel-nand-controller 10000000.ebi:nand-controller: tRLOH_min: 0, tRP_m= in: 50000, tRR_min: 40000, tRST_max: 250000000000 atmel-nand-controller 10000000.ebi:nand-controller: tWB_max: 200000, tW= C_min: 100000, tWH_min: 30000, tWHR_min: 120000 atmel-nand-controller 10000000.ebi:nand-controller: tWP_min: 50000, tWW= _min: 100000 atmel-nand-controller 10000000.ebi:nand-controller: smcconf: setup: 0x0= 0000002, pulse: 0x0f080f08, cycle: 0x000f000f, timings: 0x88060483, mod= e: 0x001f0003 nand: device found, Manufacturer ID: 0x01, Chip ID: 0xda nand: AMD/Spansion S34ML02G1 nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 onfi timings: t_prog: 0x02BC, t_bers: 0x2710, t_r: 0x0019, t_ccs: 0x006= 4 atmel-nand-controller 10000000.ebi:nand-controller: atmel_smc_nand_setu= p_data_interface(csline: -1, type: 0) atmel-nand-controller 10000000.ebi:nand-controller: tBERS_max: 14100654= 08, tCCS_min: 100000, tPROG_max: 700000000, tR_max: 25000000 atmel-nand-controller 10000000.ebi:nand-controller: tALH_min: 5000, tAD= L_min: 400000, tALS_min: 10000, tAR_min: 10000 atmel-nand-controller 10000000.ebi:nand-controller: tCEA_max: 25000, tC= EH_min: 20000, tCH_min: 5000, tCHZ_max: 30000 atmel-nand-controller 10000000.ebi:nand-controller: tCLH_min: 5000, tCL= R_min: 10000, tCLS_min: 10000, tCOH_min: 15000 atmel-nand-controller 10000000.ebi:nand-controller: tCS_min: 20000, tDH= _min: 5000, tDS_min: 10000, tFEAT_max: 1000000 atmel-nand-controller 10000000.ebi:nand-controller: tIR_min: 0, tITC_ma= x: 1000000, tRC_min: 25000, tREA_max: 20000 atmel-nand-controller 10000000.ebi:nand-controller: tREH_min: 10000, tR= HOH_min: 15000, tRHW_min: 100000, tRHZ_max: 100000 atmel-nand-controller 10000000.ebi:nand-controller: tRLOH_min: 5000, tR= P_min: 12000, tRR_min: 20000, tRST_max: 500000000 atmel-nand-controller 10000000.ebi:nand-controller: tWB_max: 100000, tW= C_min: 25000, tWH_min: 10000, tWHR_min: 80000 atmel-nand-controller 10000000.ebi:nand-controller: tWP_min: 12000, tWW= _min: 100000 atmel-nand-controller 10000000.ebi:nand-controller: atmel_smc_nand_prep= are_smcconf() failed: -524 onfi timings: t_prog: 0x02BC, t_bers: 0x2710, t_r: 0x0019, t_ccs: 0x006= 4 atmel-nand-controller 10000000.ebi:nand-controller: atmel_smc_nand_setu= p_data_interface(csline: -1, type: 0) atmel-nand-controller 10000000.ebi:nand-controller: tBERS_max: 14100654= 08, tCCS_min: 100000, tPROG_max: 700000000, tR_max: 25000000 atmel-nand-controller 10000000.ebi:nand-controller: tALH_min: 5000, tAD= L_min: 400000, tALS_min: 10000, tAR_min: 10000 atmel-nand-controller 10000000.ebi:nand-controller: tCEA_max: 25000, tC= EH_min: 20000, tCH_min: 5000, tCHZ_max: 50000 atmel-nand-controller 10000000.ebi:nand-controller: tCLH_min: 5000, tCL= R_min: 10000, tCLS_min: 10000, tCOH_min: 15000 atmel-nand-controller 10000000.ebi:nand-controller: tCS_min: 25000, tDH= _min: 5000, tDS_min: 10000, tFEAT_max: 1000000 atmel-nand-controller 10000000.ebi:nand-controller: tIR_min: 0, tITC_ma= x: 1000000, tRC_min: 30000, tREA_max: 20000 atmel-nand-controller 10000000.ebi:nand-controller: tREH_min: 10000, tR= HOH_min: 15000, tRHW_min: 100000, tRHZ_max: 100000 atmel-nand-controller 10000000.ebi:nand-controller: tRLOH_min: 0, tRP_m= in: 15000, tRR_min: 20000, tRST_max: 500000000 atmel-nand-controller 10000000.ebi:nand-controller: tWB_max: 100000, tW= C_min: 30000, tWH_min: 10000, tWHR_min: 80000 atmel-nand-controller 10000000.ebi:nand-controller: tWP_min: 15000, tWW= _min: 100000 atmel-nand-controller 10000000.ebi:nand-controller: smcconf: setup: 0x0= 0000001, pulse: 0x06030603, cycle: 0x00060006, timings: 0x88030282, mod= e: 0x001b0003 atmel-nand-controller 10000000.ebi:nand-controller: atmel_smc_nand_setu= p_data_interface(csline: 0, type: 0) atmel-nand-controller 10000000.ebi:nand-controller: tBERS_max: 14100654= 08, tCCS_min: 100000, tPROG_max: 700000000, tR_max: 25000000 atmel-nand-controller 10000000.ebi:nand-controller: tALH_min: 5000, tAD= L_min: 400000, tALS_min: 10000, tAR_min: 10000 atmel-nand-controller 10000000.ebi:nand-controller: tCEA_max: 25000, tC= EH_min: 20000, tCH_min: 5000, tCHZ_max: 50000 atmel-nand-controller 10000000.ebi:nand-controller: tCLH_min: 5000, tCL= R_min: 10000, tCLS_min: 10000, tCOH_min: 15000 atmel-nand-controller 10000000.ebi:nand-controller: tCS_min: 25000, tDH= _min: 5000, tDS_min: 10000, tFEAT_max: 1000000 atmel-nand-controller 10000000.ebi:nand-controller: tIR_min: 0, tITC_ma= x: 1000000, tRC_min: 30000, tREA_max: 20000 atmel-nand-controller 10000000.ebi:nand-controller: tREH_min: 10000, tR= HOH_min: 15000, tRHW_min: 100000, tRHZ_max: 100000 atmel-nand-controller 10000000.ebi:nand-controller: tRLOH_min: 0, tRP_m= in: 15000, tRR_min: 20000, tRST_max: 500000000 atmel-nand-controller 10000000.ebi:nand-controller: tWB_max: 100000, tW= C_min: 30000, tWH_min: 10000, tWHR_min: 80000 atmel-nand-controller 10000000.ebi:nand-controller: tWP_min: 15000, tWW= _min: 100000 atmel-nand-controller 10000000.ebi:nand-controller: smcconf: setup: 0x0= 0000001, pulse: 0x06030603, cycle: 0x00060006, timings: 0x88030282, mod= e: 0x001b0003 So, the system boots again, meaning it can successfully read from the=20= ubifs. The resulting timings are the same as in debug output: $ devmem 0xffffec30 0x00000001 $ devmem 0xffffec34 0x06030603 $ devmem 0xffffec38 0x00060006 $ devmem 0xffffec3c 0x001B0003 One thing I noticed is the tBERS_max value. From the 0x2710 in=20 the onfi page I would assume 10000 =B5s, so 10.000.000 ns, so=20 10.000.000.000 ps, which does not fit in an u32 anymore, which gives=20= those 1410065408 due to integer overflow. I didn't check the other=20 timings for possible overflow, maybe you can do this? Greets Alex