public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>, computersforpeace@gmail.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd-utils: fs-tests: pass TEST_DIR to integck in run_all.sh
Date: Tue, 30 Jun 2015 09:33:22 +0200	[thread overview]
Message-ID: <55924642.2030902@nod.at> (raw)
In-Reply-To: <1435567759-32518-1-git-send-email-yangds.fnst@cn.fujitsu.com>

Am 29.06.2015 um 10:49 schrieb Dongsheng Yang:
> Test integck requires a parameter but run_all.sh did no pass any to it.
> Then:
> integck: error!: test file-system was not specified (use -h for help)
> 
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
>  tests/fs-tests/run_all.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/fs-tests/run_all.sh b/tests/fs-tests/run_all.sh
> index 7c82921..cb481ab 100755
> --- a/tests/fs-tests/run_all.sh
> +++ b/tests/fs-tests/run_all.sh
> @@ -16,7 +16,7 @@ rm -rf ${TEST_DIR}/*
>  
>  rm -rf ${TEST_DIR}/*
>  
> -./integrity/integck || exit 1
> +./integrity/integck $TEST_DIR|| exit 1

Hmm, so, run_all.sh never worked as expected?
TBH I run integck always by hand, so at least I have never noticed.

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

  parent reply	other threads:[~2015-06-30  7:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29  8:49 [PATCH 1/2] mtd-utils: fs-tests: pass TEST_DIR to integck in run_all.sh Dongsheng Yang
2015-06-29  8:49 ` [PATCH 2/2] mtd-utils: ubi-tests: fix a some overflows Dongsheng Yang
2015-06-30  7:32   ` Richard Weinberger
2015-07-06 21:45   ` Brian Norris
2015-06-30  7:33 ` Richard Weinberger [this message]
2015-07-06 21:42 ` [PATCH 1/2] mtd-utils: fs-tests: pass TEST_DIR to integck in run_all.sh Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55924642.2030902@nod.at \
    --to=richard@nod.at \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=yangds.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox