From: Sheng Yong <shengyong1@huawei.com>
To: <computersforpeace@gmail.com>, <dwmw2@infradead.org>
Cc: <richard@nod.at>, <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH V3 0/2] mtd: nandsim: fix error handling
Date: Tue, 7 Jul 2015 10:36:59 +0800 [thread overview]
Message-ID: <559B3B4B.4010502@huawei.com> (raw)
In-Reply-To: <1435198994-110948-1-git-send-email-shengyong1@huawei.com>
Ping.
thanks,
Sheng
On 6/25/2015 10:23 AM, Sheng Yong wrote:
> V3:
> Fix compiling error of PATCH 2 because of my silly bindly rebase without
> testing :( These 2 patches are already tested.
>
> V2:
> Resend the patches against l2-mtd/master.
>
> V1:
> These 2 patches fix error handling when nandsim initialization fails.
>
> In alloc_device(), if creating slab memory fails, free_device() will try
> to destroy the slab memory without checking if it exists. PATCH 1 fixes
> it.
>
> If something goes wrong in init_nandsim(), it calls free_device() before
> returning. However, the caller of init_nandsim() - ns_init_module() - also
> does the cleanup by calling free_nandsim(). This causes double free. PATCH
> 2 fixes it.
>
> Thanks,
> Sheng
>
> Sheng Yong (2):
> mtd: nandsim: fix free of NULL pointer
> mtd: nandsim: fix double free
>
> drivers/mtd/nand/nandsim.c | 28 +++++++++-------------------
> 1 file changed, 9 insertions(+), 19 deletions(-)
>
next prev parent reply other threads:[~2015-07-07 2:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 2:23 [PATCH V3 0/2] mtd: nandsim: fix error handling Sheng Yong
2015-06-25 2:23 ` [PATCH V3 1/2] mtd: nandsim: fix free of NULL pointer Sheng Yong
2015-06-25 2:23 ` [PATCH V3 2/2] mtd: nandsim: fix double free Sheng Yong
2015-07-07 2:36 ` Sheng Yong [this message]
2015-07-07 19:59 ` [PATCH V3 0/2] mtd: nandsim: fix error handling Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559B3B4B.4010502@huawei.com \
--to=shengyong1@huawei.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox