Re: [PATCH 1/2] ubifs: Kconfig: fix the description in Kconfig

[Dongsheng Yang <yangds.fnst@cn.fujitsu.com>]

On 07/31/2015 12:47 AM, Brian Norris wrote:
> On Wed, Jul 01, 2015 at 01:29:59PM +0800, Dongsheng Yang wrote:
>> If unsure we would say 'N' rather than 'Y'.
>>
>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>> ---
>>   fs/ubifs/Kconfig | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
>> index ba66d50..f9aaad1 100644
>> --- a/fs/ubifs/Kconfig
>> +++ b/fs/ubifs/Kconfig
>> @@ -27,11 +27,11 @@ config UBIFS_FS_LZO
>>   	default y
>>   	help
>>   	   LZO compressor is generally faster than zlib but compresses worse.
>> -	   Say 'Y' if unsure.
>> +	   Say 'N' if unsure.
>
> Why would we recommend 'N' yet set the default to 'Y'? Seems like
> some dissonance.

OMG, that's TRUE. I can not recall what I was thinking when I sent
this patch, but I believe there was something wrong in my mind.

Thanx a lot to point it out, Brian.

Atem and Richard, Please ignore this noise. My bad :(.

Yang
>
> Also, I'm not an expert on UBIFS, but I imagine the suggestion to say
> yes is because of legacy support; what if you need to mount a file
> system that was created with LZO?
>
>>
>>   config UBIFS_FS_ZLIB
>>   	bool "ZLIB compression support" if UBIFS_FS_ADVANCED_COMPR
>>   	depends on UBIFS_FS
>>   	default y
>>   	help
>> -	  Zlib compresses better than LZO but it is slower. Say 'Y' if unsure.
>> +	  Zlib compresses better than LZO but it is slower. Say 'N' if unsure.
>
> Same here.
>
> Brian
> .
>