From: Graham Moore <grmoore@opensource.altera.com>
To: vikas <vikas.manocha@st.com>
Cc: Marek Vasut <marex@denx.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Alan Tull <atull@opensource.altera.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Dinh Nguyen <dinguyen@opensource.altera.com>,
"Yves Vandervennet" <yvanderv@opensource.altera.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH V7 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller.
Date: Tue, 18 Aug 2015 14:17:42 -0500 [thread overview]
Message-ID: <55D384D6.9040303@opensource.altera.com> (raw)
In-Reply-To: <55D299CD.2070809@st.com>
Hi Vikas,
On 08/17/2015 09:34 PM, vikas wrote:
> Hi Marek,
>
[...]
>> +
>> +/* Operation timeout value */
>> +#define CQSPI_TIMEOUT_MS 500
>> +#define CQSPI_READ_TIMEOUT_MS 10
>
> please add some comment about the timeouts value selection.
>
I wish I could comment, but I don't know the origin of these values.
The 500 ms value is probably just "a very long time".
[...]
>> +
>> + cqspi->irq_mask = CQSPI_IRQ_MASK_RD;
>> + writel(cqspi->irq_mask, reg_base + CQSPI_REG_IRQMASK);
>
> here interrupt mask is being configured for every read, better would be to move it in init.
>
[...]
>> +
>> + cqspi->irq_mask = CQSPI_IRQ_MASK_WR;
>> + writel(cqspi->irq_mask, reg_base + CQSPI_REG_IRQMASK);
>
> same like read, it should be moved to init.
>
It uses different masks for read and write
[...]
BR,
Graham
next prev parent reply other threads:[~2015-08-18 19:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 3:28 [PATCH V7 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Marek Vasut
2015-08-14 3:28 ` [PATCH V7 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller Marek Vasut
2015-08-14 3:32 ` Marek Vasut
2015-08-18 2:47 ` Brian Norris
2015-08-21 5:32 ` Marek Vasut
2015-08-18 2:34 ` vikas
2015-08-18 19:17 ` Graham Moore [this message]
2015-08-18 20:35 ` vikas
2015-08-21 4:04 ` Marek Vasut
2015-08-21 7:09 ` Vikas MANOCHA
2015-08-18 2:35 ` [PATCH V7 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver vikas
2015-08-18 4:47 ` Marek Vasut
2015-08-18 5:48 ` Vikas MANOCHA
2015-08-18 19:03 ` Graham Moore
2015-08-18 20:18 ` vikas
2015-08-20 4:03 ` Marek Vasut
2015-08-20 16:06 ` vikas
2015-08-21 3:46 ` Marek Vasut
2015-08-21 7:00 ` Vikas MANOCHA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D384D6.9040303@opensource.altera.com \
--to=grmoore@opensource.altera.com \
--cc=atull@opensource.altera.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=vikas.manocha@st.com \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).