From: Richard Weinberger <richard@nod.at>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>,
viro@ZenIV.linux.org.uk, jack@suse.cz, dedekind1@gmail.com,
richard.weinberger@gmail.com
Cc: linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 14/35] ubifs: extend budget for blocks
Date: Fri, 21 Aug 2015 09:12:37 +0200 [thread overview]
Message-ID: <55D6CF65.3020103@nod.at> (raw)
In-Reply-To: <55D6BE42.6090507@cn.fujitsu.com>
Am 21.08.2015 um 07:59 schrieb Dongsheng Yang:
> On 08/04/2015 04:56 AM, Richard Weinberger wrote:
>> Am 30.07.2015 um 07:48 schrieb Dongsheng Yang:
>>> Currently, budget subsystem in ubifs are working on budgeting
>
> [...]
>>> #endif
>>> + unsigned int new_block_num;
>>> + unsigned int dirtied_block_num;
>>
>> Why are these not under UBIFS_DEBUG?
>> I like the overflow checks.
>
> Sorry for the late reply.
>
> I did not find the overflow checks in my reading.
> Could you help to explain what kind of the check
> is it? and why we define in different way with
> UBIFS_DEBUG defined or not.
AFAICT the idea is that you see it from the value
from a crash dump.
i.e. if new_page is > 2 an overflow happened.
I don't know that Artem's original plan was.
But we could also automate this checks.
> And, Where did we define the UBIFS_DEBUG? I did not
> get the design of this macro. :(
You have define the macro yourself.
Thanks,
//richard
next prev parent reply other threads:[~2015-08-21 7:13 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 5:47 [PATCH v2 00/35] Add quota supporting in ubifs Dongsheng Yang
2015-07-30 5:47 ` [PATCH v2 01/35] fs: introduce a ->s_cdev field into struct super_block Dongsheng Yang
2015-07-30 5:47 ` [PATCH v2 02/35] fs: cleanup: remove the blank line before EXPORT_SYMBOL Dongsheng Yang
2015-07-30 5:47 ` [PATCH v2 03/35] fs: super: cleanup: make the comment of each function aligned Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 04/35] fs: super: consolidate the get_super class functions Dongsheng Yang
2015-08-03 19:50 ` Jan Kara
2015-07-30 5:48 ` [PATCH v2 05/35] fs: super: introduce a get_super_cdev to get super by a cdev reference Dongsheng Yang
2015-08-03 19:51 ` Jan Kara
2015-07-30 5:48 ` [PATCH v2 06/35] fs: super: introduce a get_super_cdev_thawed to get sb by " Dongsheng Yang
2015-08-03 19:56 ` Jan Kara
2015-07-30 5:48 ` [PATCH v2 07/35] fs: char_dev: introduce cd_acquire function to acquire cdev Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 08/35] fs: introduce a __lookup_dev for internal using Dongsheng Yang
2015-08-03 20:08 ` Jan Kara
2015-08-03 20:13 ` Jan Kara
2015-07-30 5:48 ` [PATCH v2 09/35] fs: char_dev: introduce lookup_cdev to get cdev by pathname Dongsheng Yang
2015-08-03 20:08 ` Jan Kara
2015-07-30 5:48 ` [PATCH v2 10/35] fs: dquot: skip invalidate_bdev if bdev is NULL Dongsheng Yang
2015-08-03 20:04 ` Jan Kara
2015-07-30 5:48 ` [PATCH v2 11/35] fs: quota: make quota support fs which is running on char dev Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 12/35] ubi: introduce a interface to get cdev in ubi_volume Dongsheng Yang
2015-08-03 20:56 ` Richard Weinberger
2015-07-30 5:48 ` [PATCH v2 13/35] ubifs: fix a typo in comment of ubifs_budget_req Dongsheng Yang
2015-08-03 20:56 ` Richard Weinberger
2015-08-10 8:21 ` Artem Bityutskiy
2015-07-30 5:48 ` [PATCH v2 14/35] ubifs: extend budget for blocks Dongsheng Yang
2015-08-03 20:56 ` Richard Weinberger
2015-08-21 5:59 ` Dongsheng Yang
2015-08-21 7:12 ` Richard Weinberger [this message]
2015-08-21 7:55 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 15/35] ubifs: fill sb->s_cdev in ubifs_fill_super() Dongsheng Yang
2015-08-03 20:58 ` Richard Weinberger
2015-07-30 5:48 ` [PATCH v2 16/35] ubifs: fill ->s_dev in ubifs_fill_super Dongsheng Yang
2015-08-03 21:00 ` Richard Weinberger
2015-07-30 5:48 ` [PATCH v2 17/35] ubifs: export read_block() from file.c Dongsheng Yang
2015-08-03 21:13 ` Richard Weinberger
2015-08-03 21:29 ` Richard Weinberger
2015-08-07 3:15 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 18/35] ubifs: introduce quota related mount options Dongsheng Yang
2015-08-03 21:13 ` Richard Weinberger
2015-08-07 3:17 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 19/35] ubifs: budget for inode in ubifs_dirty_inode if necessary Dongsheng Yang
2015-08-03 21:13 ` Richard Weinberger
2015-08-07 3:18 ` Dongsheng Yang
2015-08-05 8:11 ` Artem Bityutskiy
2015-08-06 6:46 ` Dongsheng Yang
2015-08-06 7:26 ` Artem Bityutskiy
2015-08-06 7:30 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 20/35] ubifs: implement IO functions for quota files Dongsheng Yang
2015-08-03 21:46 ` Richard Weinberger
2015-08-05 1:21 ` Dongsheng Yang
2015-08-07 3:24 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 21/35] ubifs: disable quota in ubifs_put_super Dongsheng Yang
2015-08-08 21:08 ` Richard Weinberger
2015-08-10 2:03 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 22/35] ubifs: write quota back in ubifs_sync Dongsheng Yang
2015-08-08 21:17 ` Richard Weinberger
2015-07-30 5:48 ` [PATCH v2 23/35] ubifs: set/clear MS_RDONLY properly in ubifs_remount Dongsheng Yang
2015-08-08 21:17 ` Richard Weinberger
2015-08-10 2:46 ` Dongsheng Yang
2015-08-24 1:29 ` Dongsheng Yang
2015-08-24 7:02 ` Artem Bityutskiy
2015-08-24 7:12 ` Dongsheng Yang
2015-08-24 7:26 ` Artem Bityutskiy
2015-08-27 2:52 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 24/35] ubifs: suspend & resume quota " Dongsheng Yang
2015-08-08 21:24 ` Richard Weinberger
2015-08-10 2:04 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 25/35] ubifs: record quota information about inode in ubifs_new_inode Dongsheng Yang
2015-08-08 21:43 ` Richard Weinberger
2015-08-10 2:13 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 26/35] ubifs: free quota inode information in ubifs_evict_inode Dongsheng Yang
2015-08-08 21:51 ` Richard Weinberger
2015-08-10 3:09 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 27/35] ubifs: alloc quota space in ubifs_write_begin Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 28/35] ubifs: free quota space in do_truncation Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 29/35] ubifs: free quota space when deleting a file Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 30/35] ubifs: adapt quota space informatin in do_setattr Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 31/35] ubifs: transfer quota information in changing owner or group Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 32/35] ubifs: write inode in ubifs_quota_write if we are appending Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 33/35] fs: introduce a get_qsize() to file_operations Dongsheng Yang
2015-08-03 20:15 ` Jan Kara
2015-08-07 3:30 ` Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 34/35] ubifs: implement ubifs_get_qsize to get quota size in ubifs Dongsheng Yang
2015-07-30 5:48 ` [PATCH v2 35/35] ubifs: make ubifs to support quota Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D6CF65.3020103@nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).