From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.s-osg.org ([54.187.51.154]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZSwdv-0006C6-89 for linux-mtd@lists.infradead.org; Sat, 22 Aug 2015 00:26:44 +0000 Subject: Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information To: Brian Norris References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-4-git-send-email-javier@osg.samsung.com> <20150820215404.GA81844@google.com> <55D6510E.7010002@osg.samsung.com> <20150820223440.GC81844@google.com> <55D65B72.2050006@osg.samsung.com> <20150821224714.GD81844@google.com> Cc: linux-kernel@vger.kernel.org, Mark Brown , linux-mtd@lists.infradead.org, David Woodhouse From: Javier Martinez Canillas Message-ID: <55D7C1A6.20000@osg.samsung.com> Date: Sat, 22 Aug 2015 02:26:14 +0200 MIME-Version: 1.0 In-Reply-To: <20150821224714.GD81844@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello Brian, On 08/22/2015 12:47 AM, Brian Norris wrote: > Hi Javier, > > On Fri, Aug 21, 2015 at 12:57:54AM +0200, Javier Martinez Canillas wrote: >> On 08/21/2015 12:34 AM, Brian Norris wrote: >>> On Fri, Aug 21, 2015 at 12:13:34AM +0200, Javier Martinez Canillas wrote: >>>> So this patch really is a no-op right now and is not fixing anything. >>>> As long as the driver has a MODULE_DEVICE_TABLE(spi,...), things will >>> >>> This driver does not have a MODULE_DEVICE_TABLE() at all, nor does it >>> use spi_device_id. So, it is currently broken for the module use case. >>> >> >> That is correct but also that does not mean that this patch will fix >> module autoloading right now. It will though once the SPI core is >> changed to report a OF type module alias. > > Ah, thanks for the patience. I missed the point that it will still be > broken. > No worries, I'm glad that we are on the same page now. >> So what about something along this lines? >> >> mtd: dataflash: Export OF module alias information >> >> The SPI core currently reports the MODALIAS uevent as "spi:" >> even for SPI devices that were registered by OF. >> >> That means the OF module alias exported by MODULE_OF_TABLE(of,...) is >> currently not used and user-space has no way to autoload this module. >> >> But is still a good practice to add the OF module alias information > > nit: s/is/it is/ > >> into the kernel module even when currently is unused so once the SPI > > ditto > >> core is changed to report a correct OF modalias uevent, module >> autoloading will be working for this driver. > > Otherwise, looks good. I'll either patch in this commit message, or > await v2. Your call. > If you don't mind fixing it up yourself when applying, then that would be really helpful. Otherwise I can post a v2 on Monday. > Regards, > Brian > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America