[PATCH] mtd-utils: serve_image: use proper POSIX_C_SOURCE value

[PATCH] mtd-utils: serve_image: use proper POSIX_C_SOURCE value

[Kirill Smirnov]

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

struct addrinfo and friends conform to POSIX.1-2001, not earlier.
This patch fixes linking against latest glibc 2.22

[-- Attachment #2: posix-2001.patch --]
[-- Type: text/x-patch, Size: 271 bytes --]

diff --git a/serve_image.c b/serve_image.c
index d3794ec..cbcf3b7 100644
--- a/serve_image.c
+++ b/serve_image.c
@@ -1,5 +1,5 @@
 #define PROGRAM_NAME "serve_image"
-#define _POSIX_C_SOURCE 199309
+#define _POSIX_C_SOURCE 200112L
 
 #include <time.h>
 #include <errno.h>

Re: [PATCH] mtd-utils: serve_image: use proper POSIX_C_SOURCE value

[Brian Norris]

On Thu, Oct 01, 2015 at 02:49:44AM +0300, Kirill Smirnov wrote:
> struct addrinfo and friends conform to POSIX.1-2001, not earlier.
> This patch fixes linking against latest glibc 2.22

Please include your 'Signed-off-by', and use inline patches, not
attachments. For reference, see the Linux patch submission guidelines:

https://www.kernel.org/doc/Documentation/SubmittingPatches

Re: [PATCH] mtd-utils: serve_image: use proper POSIX_C_SOURCE value

[Kirill Smirnov]

On 01.10.2015 04:04, Brian Norris wrote:
> On Thu, Oct 01, 2015 at 02:49:44AM +0300, Kirill Smirnov wrote:
>> struct addrinfo and friends conform to POSIX.1-2001, not earlier.
>> This patch fixes linking against latest glibc 2.22
>
> Please include your 'Signed-off-by', and use inline patches, not
> attachments. For reference, see the Linux patch submission guidelines:
>
> https://www.kernel.org/doc/Documentation/SubmittingPatches
>
I've resent the patch. I'm sorry, while re-formatting mail I forgot to 
remove attachment, so it has been shipped along with the proper inline 
patch. Is it OK?

[PATCH] mtd-utils: serve_image: use proper POSIX_C_SOURCE value

[Kirill Smirnov]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

struct addrinfo and friends conform to POSIX.1-2001, not earlier.
This patch fixes linking against latest glibc 2.22

Now email formatting and the generated patch should be OK.

Signed-off-by: Kirill Smirnov <kirill.k.smirnov@gmail.com>
---
serve_image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/serve_image.c b/serve_image.c
index d3794ec..cbcf3b7 100644
--- a/serve_image.c
+++ b/serve_image.c
@@ -1,5 +1,5 @@
#define PROGRAM_NAME "serve_image"
-#define _POSIX_C_SOURCE 199309
+#define _POSIX_C_SOURCE 200112L

#include <time.h>
#include <errno.h>
-- 
2.5.1


[-- Attachment #2: posix-2001.patch --]
[-- Type: text/x-patch, Size: 272 bytes --]

diff --git a/serve_image.c b/serve_image.c
index d3794ec..cbcf3b7 100644
--- a/serve_image.c
+++ b/serve_image.c
@@ -1,5 +1,5 @@
 #define PROGRAM_NAME "serve_image"
-#define _POSIX_C_SOURCE 199309
+#define _POSIX_C_SOURCE 200112L
 
 #include <time.h>
 #include <errno.h>

Re: [PATCH] mtd-utils: serve_image: use proper POSIX_C_SOURCE value

[Brian Norris]

On Thu, Oct 01, 2015 at 04:19:35AM +0300, Kirill Smirnov wrote:
> struct addrinfo and friends conform to POSIX.1-2001, not earlier.
> This patch fixes linking against latest glibc 2.22
> 
> Now email formatting and the generated patch should be OK.

Normally we don't include lines like this ^^ in the commit message.

> Signed-off-by: Kirill Smirnov <kirill.k.smirnov@gmail.com>
> ---

But you can include comments like that (that don't belong in the commit
message) here, below the '---'.

Also, the extra attachment is not too much of a problem, but try to
avoid it in the future.

Anyway, patch looks reasonable to me. Applied to mtd-utils.git. Thanks!

Brian

> serve_image.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/serve_image.c b/serve_image.c
> index d3794ec..cbcf3b7 100644
> --- a/serve_image.c
> +++ b/serve_image.c
> @@ -1,5 +1,5 @@
> #define PROGRAM_NAME "serve_image"
> -#define _POSIX_C_SOURCE 199309
> +#define _POSIX_C_SOURCE 200112L
> 
> #include <time.h>
> #include <errno.h>
> -- 
> 2.5.1