From: Heiner Kallweit <hkallweit1@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: Brian Norris <computersforpeace@gmail.com>
Subject: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading
Date: Sat, 3 Oct 2015 23:54:16 +0200 [thread overview]
Message-ID: <56104E88.3040807@gmail.com> (raw)
Seems like commit 43163022927b6e7d202a7e6f939c3f392465494d
(allow arbitrary OF matching for "jedec,spi-nor") broke autoloading
of the m25p80 module.
MODALIAS is "spi:spi-nor" and removing "spi-nor" as device alias
prevents module autoloading.
Of course we could revert the removal of the "spi-nor" device alias.
However it might be better to switch to DT-based matching for
DT-configured devices.
Adding a call to of_device_uevent_modalias to spi_uevent in spi.c
solved the issue for me, drawback however is that just the first
"compatible" value is used as modalias. In case of m25p80 this means
that "jedec,spi-nor" has to be the first "compatible" value.
This constraint might be too strict ..
Having said that I'm not sure what could be a better way to fix
the issue than just re-introducing the "spi-nor" device alias.
next reply other threads:[~2015-10-03 21:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 21:54 Heiner Kallweit [this message]
2015-11-12 18:59 ` m25p80: Commit "allow arbitrary OF matching for "jedec, spi-nor"" breaks module autoloading Brian Norris
2015-11-13 19:40 ` spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading) Brian Norris
2015-11-13 22:12 ` Mark Brown
2015-11-13 22:51 ` Brian Norris
2015-11-13 23:14 ` Mark Brown
2015-11-13 23:48 ` Brian Norris
2015-11-16 13:53 ` Mark Brown
2015-11-16 17:26 ` spi: OF module autoloading is still broken Javier Martinez Canillas
2015-11-16 17:51 ` Mark Brown
2015-11-16 18:00 ` Javier Martinez Canillas
2015-11-16 17:19 ` Javier Martinez Canillas
2015-11-16 17:49 ` Mark Brown
2015-11-16 17:57 ` Javier Martinez Canillas
2015-11-16 19:24 ` Brian Norris
2015-11-16 20:00 ` Javier Martinez Canillas
2015-11-16 20:47 ` Brian Norris
2015-11-16 21:32 ` Javier Martinez Canillas
2015-11-16 21:51 ` Brian Norris
2015-11-17 13:14 ` Javier Martinez Canillas
2015-11-17 13:19 ` Mark Brown
2015-11-17 13:36 ` Javier Martinez Canillas
2015-11-18 20:07 ` Javier Martinez Canillas
2015-11-19 12:47 ` Javier Martinez Canillas
2015-11-17 13:34 ` Mark Brown
2015-11-17 13:38 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56104E88.3040807@gmail.com \
--to=hkallweit1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).