From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: Richard Weinberger <richard@nod.at>, <dedekind1@gmail.com>,
<computersforpeace@gmail.com>
Cc: <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 10/27] ubifs: introduce list.h
Date: Thu, 8 Oct 2015 08:02:40 +0800 [thread overview]
Message-ID: <5615B2A0.1010803@cn.fujitsu.com> (raw)
In-Reply-To: <5615838E.5090908@nod.at>
On 10/08/2015 04:41 AM, Richard Weinberger wrote:
> Am 19.08.2015 um 10:39 schrieb Dongsheng Yang:
>> Copy the list.h from kernel to ubifs-utils/
>>
>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>> ---
>> ubifs-utils/include/list.h | 484 +++++++++++++++++++++++++++++++++++++++++++++
>
> This belongs to common mtd-utils code as it is not UBIFS specific.
Yes, It's in my TODO, but I did not put it at this time, because
there is a list implementation in jffs2 part, IIRC. So I am planing
to do it later to move all common code into higher level.
> And why didn't you copy the whole list.h file?
Hmmmm.....I only implemented what I required in this patchset. The
commit message is confusing, It's not a *copy* from kernel. Maybe
it's better that "Implement list structure in ubifs-utils like kernel."
> I'm missing
> list_last_entry() for example.
If you want something more, I think it's okey to add them into list.h
Thanx
Yang
>
> Thanks,
> //richard
>
next prev parent reply other threads:[~2015-10-08 0:09 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 8:39 [RFC PATCH 00/27] Introduce ubifs_dump in ubifs-utils Dongsheng Yang
2015-08-19 8:39 ` [PATCH 01/27] mtd-utils: Restructure the mtd-utils source Dongsheng Yang
2015-08-19 8:39 ` [PATCH 02/27] ubifs: pick some common definitions into ubifs_common.h Dongsheng Yang
2015-08-19 8:39 ` [PATCH 03/27] ubifs: move the all io related code into io.[h|c] Dongsheng Yang
2015-08-19 8:39 ` [PATCH 04/27] ubifs: remove the including of mkfs.ubifs.h in lpt.c Dongsheng Yang
2015-08-19 8:39 ` [PATCH 05/27] ubifs: cut off the dependence from compr.o to mkfs.ubifs Dongsheng Yang
2015-08-19 8:39 ` [PATCH 06/27] ubifs: cut off the dependence from devtable to mkfs.ubifs.h Dongsheng Yang
2015-08-19 8:39 ` [PATCH 07/27] ubifs: introduce ubifs-utils/include and ubifs-utils/lib Dongsheng Yang
2015-08-19 8:39 ` [PATCH 08/27] ubifs: move more functions into io lib Dongsheng Yang
2015-08-19 8:39 ` [PATCH 09/27] ubifs: introduce a new tool ubifs_dump Dongsheng Yang
2015-08-19 8:39 ` [PATCH 10/27] ubifs: introduce list.h Dongsheng Yang
2015-10-07 20:41 ` Richard Weinberger
2015-10-08 0:02 ` Dongsheng Yang [this message]
2015-08-19 8:39 ` [PATCH 11/27] ubifs: copy some important data in ubifs.h from kernel to ubifs-utils Dongsheng Yang
2015-08-19 8:39 ` [PATCH 12/27] ubifs: copy some important functions in key.h " Dongsheng Yang
2015-08-19 8:39 ` [PATCH 13/27] ubifs: ubifs_dump: add dump_ch and dump_node functions Dongsheng Yang
2015-08-19 8:39 ` [PATCH 14/27] ubifs: defs.h: introduce some compatible definition for printk class Dongsheng Yang
2015-08-19 8:39 ` [PATCH 15/27] ubifs: io: introduce ubifs_read function to read ubi volume Dongsheng Yang
2015-08-19 8:39 ` [PATCH 16/27] ubifs: ubifs_dump: dump super block Dongsheng Yang
2015-08-19 8:39 ` [PATCH 17/27] ubifs: introduce scan for ubifs-utils Dongsheng Yang
2015-08-19 8:39 ` [PATCH 18/27] ubifs: add some more compatible definitions in defs.h Dongsheng Yang
2015-08-19 8:39 ` [PATCH 19/27] ubifs: ubifs_dump: dump master node Dongsheng Yang
2015-10-08 10:07 ` David Gstir
2015-10-09 3:52 ` Dongsheng Yang
2015-10-09 4:05 ` [PATCH v2] " Dongsheng Yang
2015-10-09 4:06 ` Dongsheng Yang
2015-08-19 8:39 ` [PATCH 20/27] ubifs: ubifs_dump: dump log area Dongsheng Yang
2015-08-19 8:39 ` [PATCH 21/27] ubifs: introduce lprops lib Dongsheng Yang
2015-08-19 8:39 ` [PATCH 22/27] ubifs: lpt: implement functions to scan lpt Dongsheng Yang
2015-08-19 8:39 ` [PATCH 23/27] ubifs: ubifs_dump: dump lpt area Dongsheng Yang
2015-08-19 8:39 ` [PATCH 24/27] ubifs: ubifs_dump: dump index area Dongsheng Yang
2015-09-24 6:25 ` Richard Weinberger
2015-09-24 6:32 ` Dongsheng Yang
2015-09-24 6:46 ` [PATCH v2] " Dongsheng Yang
2015-08-19 8:39 ` [PATCH 25/27] ubifs: defs.h: introduce some compatible definitions about integer such as __u16 Dongsheng Yang
2015-08-19 8:39 ` [PATCH 26/27] ubifs: introduce hexdump lib Dongsheng Yang
2015-08-19 8:39 ` [PATCH 27/27] ubifs: ubifs_dump: dump data in hex format Dongsheng Yang
2015-08-19 8:48 ` [RFC PATCH 00/27] Introduce ubifs_dump in ubifs-utils Dongsheng Yang
2015-08-19 20:45 ` Richard Weinberger
2015-08-20 3:07 ` Dongsheng Yang
2015-09-16 13:32 ` Richard Weinberger
2015-09-17 5:39 ` Dongsheng Yang
2015-09-17 21:21 ` Richard Weinberger
2015-09-18 2:23 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5615B2A0.1010803@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).