From: Richard Weinberger <richard@nod.at>
To: dedekind1@gmail.com, linux-mtd@lists.infradead.org
Cc: boris.brezillon@free-electrons.com, alex@nextthing.co
Subject: Re: [PATCH 3/5] UBI: Expose the bitrot interface
Date: Fri, 6 Nov 2015 13:14:08 +0100 [thread overview]
Message-ID: <563C9990.4040602@nod.at> (raw)
In-Reply-To: <1446811178.20949.111.camel@gmail.com>
Am 06.11.2015 um 12:59 schrieb Artem Bityutskiy:
> On Thu, 2015-11-05 at 23:56 +0100, Richard Weinberger wrote:
>> +#define UBI_IOCRPEB _IOW(UBI_IOC_MAGIC, 4, __s32)
>> +#define UBI_IOCSPEB _IOW(UBI_IOC_MAGIC, 5, __s32)
>
> Could you please, add short comments telling what are these ioctls
> about.
Sure.
Something like:
+/* Trigger re-read of a given PEB */
+#define UBI_IOCRPEB _IOW(UBI_IOC_MAGIC, 4, __s32)
+/* Trigger scrubbing of a given PEB */
+#define UBI_IOCSPEB _IOW(UBI_IOC_MAGIC, 5, __s32)
?
While we're here, would it make sense to do a manpage for UBI's ioctl()s?
Thanks,
//richard
next prev parent reply other threads:[~2015-11-06 12:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 22:56 [RFC] UBI statistics and bitrot interface Richard Weinberger
2015-11-05 22:56 ` [PATCH 1/5] UBI: Introduce prepare_erase_work() Richard Weinberger
2015-11-05 22:56 ` [PATCH 2/5] UBI: Introduce in_pq() Richard Weinberger
2015-11-05 22:56 ` [PATCH 3/5] UBI: Expose the bitrot interface Richard Weinberger
2015-11-06 11:59 ` Artem Bityutskiy
2015-11-06 12:14 ` Richard Weinberger [this message]
2015-11-06 12:30 ` Artem Bityutskiy
2015-11-06 12:27 ` Artem Bityutskiy
2015-11-05 22:56 ` [PATCH 4/5] UBI: Add basic read counter support Richard Weinberger
2015-11-05 22:56 ` [PATCH 5/5] UBI: Expose UBI statistics interface Richard Weinberger
2025-02-12 20:46 ` [RFC] UBI statistics and bitrot interface Ashley Herron
2025-02-12 21:58 ` Richard Weinberger
2025-02-14 16:04 ` Ashley Herron
2025-02-14 19:19 ` Richard Weinberger
2025-02-15 4:58 ` Zhihao Cheng
2025-02-15 5:21 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563C9990.4040602@nod.at \
--to=richard@nod.at \
--cc=alex@nextthing.co \
--cc=boris.brezillon@free-electrons.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).