From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
tglx@linutronix.de, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC PATCH 2/2] mtd: ubi: wl: avoid erasing a PEB which is empty
Date: Tue, 24 Nov 2015 09:42:48 +0100 [thread overview]
Message-ID: <56542308.1020409@linutronix.de> (raw)
In-Reply-To: <5654225A.9070702@nod.at>
On 11/24/2015 09:39 AM, Richard Weinberger wrote:
>>>> + } else {
>>>> + err = do_sync_erase(ubi, e2, vol_id, lnum, torture);
>>>> + if (err) {
>>>> + wl_entry_destroy(ubi, e2);
>>>
>>> Why that? The erase_worker will free e2 if it encounters
>>> a fatal error and gives up this PEB. You're introducing a double free.
>>
>> Hmmm. That is real bad error handling you have there. So you invoke
>> do_sync_erase(), the kmalloc() fails and how exactly you free e2 here?
>
> Why do you want to free e2? We free an erase entry only if we give
> it up. wear leveling entries are allocated at init time and destroyed
> when you detach UBI.
The reference to it in the RB-tree (free) was removed. Is there another
reference to it?
> Thanks,
> //richard
>
Sebastian
next prev parent reply other threads:[~2015-11-24 8:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 18:09 [RFC] avoid a live lock in wear_leveling_worker() Sebastian Andrzej Siewior
2015-11-23 18:09 ` [RFC PATCH 1/2] mtd: nand: schedule() after releasing the device Sebastian Andrzej Siewior
2015-11-23 18:18 ` Peter Zijlstra
2015-11-25 17:35 ` [PATCH] mtd: nand: do FIFO processing in nand_get_device() Sebastian Andrzej Siewior
2015-11-30 16:15 ` Peter Zijlstra
2015-12-06 14:17 ` Sebastian Andrzej Siewior
2015-12-06 14:23 ` [PATCH v2] " Sebastian Andrzej Siewior
2015-12-02 18:52 ` [PATCH] " Brian Norris
2015-12-02 20:41 ` Sebastian Andrzej Siewior
2015-11-23 18:09 ` [RFC PATCH 2/2] mtd: ubi: wl: avoid erasing a PEB which is empty Sebastian Andrzej Siewior
2015-11-23 21:30 ` Richard Weinberger
2015-11-23 21:50 ` Richard Weinberger
2015-11-24 8:26 ` Sebastian Andrzej Siewior
2015-11-24 8:39 ` Richard Weinberger
2015-11-24 8:42 ` Sebastian Andrzej Siewior [this message]
2015-11-24 9:02 ` Richard Weinberger
2015-11-24 9:07 ` Sebastian Andrzej Siewior
2015-11-24 9:16 ` Richard Weinberger
2015-11-24 12:58 ` Artem Bityutskiy
2015-11-24 13:33 ` Sebastian Andrzej Siewior
2015-11-24 13:40 ` Artem Bityutskiy
2015-11-24 13:57 ` Artem Bityutskiy
2015-11-26 14:56 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56542308.1020409@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).