linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: Bayi Cheng <bayi.cheng@mediatek.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	ezequiel@vanguardiasur.com.ar, Kumar Gala <galak@codeaurora.org>,
	jteki@openedev.com, linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node
Date: Wed, 25 Nov 2015 13:31:14 +0100	[thread overview]
Message-ID: <5655AA12.4070903@gmail.com> (raw)
In-Reply-To: <1448449042.24527.0.camel@mtksdaap41>



On 25/11/15 11:57, Yingjoe Chen wrote:
> On Wed, 2015-11-25 at 11:50 +0100, Matthias Brugger wrote:
>>
>> On 18/11/15 04:30, Bayi Cheng wrote:
>>> Add Mediatek nor flash node
>>>
>>> Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
>>> Acked-by: Brian Norris <computersforpeace@gmail.com>
>>> ---
>>>    arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +++++++++++++++++-
>>>    1 file changed, 17 insertions(+), 1 deletion(-)
>>>
>>
>> Applied to v4.5-next/dts
>>
>> Thanks.
>> Matthias
>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 4dd5f93..7988656 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -387,7 +387,23 @@
>>>    			status = "disabled";
>>>    		};
>>>
>>> -		i2c3: i2c@11010000 {
>>> +		nor_flash: spi@1100d000 {
>>> +			compatible = "mediatek,mt8173-nor";
>>> +			reg = <0 0x1100d000 0 0xe0>;
>>> +			clocks = <&pericfg CLK_PERI_SPI>,
>>> +				 <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
>>> +			clock-names = "spi", "sf";
>>> +			#address-cells = <1>;
>>> +			#size-cells = <0>;
>>> +			status = "disabled";
>>> +
>>> +			flash@0 {
>>> +				compatible = "jedec,spi-nor";
>>> +				reg = <0>;
>>> +			};
>>> +		};
>>> +
>>> +		i2c3: i2c3@11010000 {
>
> Hi Matthias,
>
> Just notice this one. Please make sure this line should be
>
> i2c3: i2c@11010000 {
>
> instead of
>
> i2c3: i2c3@11010000 {
>

Fixed, thanks for catching this.

  reply	other threads:[~2015-11-25 12:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18  3:30 [PATCH v8 0/2] Mediatek SPI-NOR flash driver Bayi Cheng
2015-11-18  3:30 ` [PATCH v8 1/2] mtd: mtk-nor: mtk serial flash controller driver Bayi Cheng
2015-11-21  1:36   ` Brian Norris
2015-11-18  3:30 ` [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node Bayi Cheng
2015-11-25 10:50   ` Matthias Brugger
2015-11-25 10:57     ` Yingjoe Chen
2015-11-25 12:31       ` Matthias Brugger [this message]
2015-11-26  1:20   ` Daniel Kurtz
2015-11-26  2:42     ` bayi cheng
2015-12-04 16:22       ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5655AA12.4070903@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=bayi.cheng@mediatek.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jteki@openedev.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=srv_heupstream@mediatek.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).