linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org, tglx@linutronix.de
Subject: Re: [PATCH 3/3] mtd: ubi: wl: avoid erasing a PEB which is empty
Date: Tue, 1 Dec 2015 20:46:09 +0100	[thread overview]
Message-ID: <565DF901.40208@nod.at> (raw)
In-Reply-To: <1448569430-885-3-git-send-email-bigeasy@linutronix.de>

Am 26.11.2015 um 21:23 schrieb Sebastian Andrzej Siewior:
> wear_leveling_worker() currently unconditionally puts a PEB on erase in
> the error case even it just been taken from the free_list and never
> used.
> In case the PEB was never used it can be put back on the free list
> saving a precious erase cycle.
> 
> v1…v2:
> 	- to_leb_clean -> dst_leb_clean
> 	- use the nested option for ensure_wear_leveling()
> 	- do_sync_erase() can't go -ENOMEM so we can just go into
> 	  RO-mode now.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Thanks a lot for the error handling cleanup and this improvement!
All three patches look good to me.
Artem, unless you have objections I'd merge them.

Thanks,
//richard

  reply	other threads:[~2015-12-01 19:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 20:23 [PATCH 1/3] mtd: ubi: fixup error correction in do_sync_erase() Sebastian Andrzej Siewior
2015-11-26 20:23 ` [PATCH 2/3] mtd: ubi: don't leak e if schedule_erase() fails Sebastian Andrzej Siewior
2015-11-26 20:23 ` [PATCH 3/3] mtd: ubi: wl: avoid erasing a PEB which is empty Sebastian Andrzej Siewior
2015-12-01 19:46   ` Richard Weinberger [this message]
2015-12-02 11:56     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565DF901.40208@nod.at \
    --to=richard@nod.at \
    --cc=bigeasy@linutronix.de \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).