From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
To: <dedekind1@gmail.com>, Richard Weinberger <richard@nod.at>,
<linux-mtd@lists.infradead.org>
Cc: <david@sigma-star.at>
Subject: Re: [PATCH 05/11] ubifs: remove ununsed ubifs context from key helpers
Date: Sun, 20 Dec 2015 11:01:01 +0800 [thread overview]
Message-ID: <567619ED.8080006@cn.fujitsu.com> (raw)
In-Reply-To: <1446478715.6126.109.camel@gmail.com>
On 11/02/2015 11:38 PM, Artem Bityutskiy wrote:
> On Mon, 2015-11-02 at 09:28 +0800, Dongsheng Yang wrote:
>> Yes, all ubifs_info *c in key.h are not used, But I am
>> not sure about is that intentional or not.
>
> Hi,
>
> the intention was that there would be multiple key formats supported,
> and these functions would look at something like c->key_format to
> figure out how to work with this key.
Thanx Artem,
Then, David and Richard, what about keep this parameter here for
scalability?
I would like to add a comment about it to point out what is that for.
Yang
>
> Right now there is only one key type, so these are not needed as of
> today.
>
> Artem.
>
next prev parent reply other threads:[~2015-12-20 3:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 11:15 [RFC] UBIFS unpacker v0 Richard Weinberger
2015-10-31 11:15 ` [PATCH 01/11] ubifs: add complete version of list.h Richard Weinberger
2015-10-31 11:15 ` [PATCH 02/11] ubifs: fix typo in ubifs_read Richard Weinberger
2015-10-31 11:15 ` [PATCH 03/11] Make cli byte parsing from ubi-utils available for all tools Richard Weinberger
2015-10-31 11:15 ` [PATCH 04/11] ubifs: add decompression functions Richard Weinberger
2015-10-31 11:15 ` [PATCH 05/11] ubifs: remove ununsed ubifs context from key helpers Richard Weinberger
2015-11-02 1:28 ` Dongsheng Yang
2015-11-02 15:38 ` Artem Bityutskiy
2015-12-20 3:01 ` Dongsheng Yang [this message]
2015-10-31 11:15 ` [PATCH 06/11] ubifs: keep scan buffer in ubifs_info Richard Weinberger
2015-10-31 11:15 ` [PATCH 07/11] ubifs: extend master scanning code Richard Weinberger
2015-10-31 11:15 ` [PATCH 08/11] ubifs: add missing include to defs.h Richard Weinberger
2015-10-31 11:15 ` [PATCH 09/11] ubifs: Add more key helper functions Richard Weinberger
2015-10-31 11:15 ` [PATCH 10/11] ubifs: add emubi, a minimal UBI emulation layer Richard Weinberger
2015-10-31 11:16 ` [PATCH 11/11] ubifs: add ubifs_unpack Richard Weinberger
2015-11-02 1:31 ` [RFC] UBIFS unpacker v0 Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567619ED.8080006@cn.fujitsu.com \
--to=yangds.fnst@cn.fujitsu.com \
--cc=david@sigma-star.at \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).