From: David Howells <dhowells@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: dhowells@redhat.com, linux-mtd@lists.infradead.org
Subject: Bug in physmap driver?
Date: Thu, 16 Apr 2009 16:00:19 +0100 [thread overview]
Message-ID: <5680.1239894019@redhat.com> (raw)
In physmap_flash_probe(), isn't the '+ 1' in:
info->map[i].size = dev->resource[i].end - dev->resource[i].start + 1;
incorrect? It results in an artificially inflated size:
(gdb) p info->map[0]
$7 = {name = 0xc08aa520 "physmap-flash.0", size = 0x200001, phys = 0xff000000, virt = 0x0, cached = 0x0, bankwidth = 0x4, read = 0, copy_from = 0, write = 0, copy_to = 0, inval_cache = 0, set_vpp = 0, pfow_base = 0x0, map_priv_1 = 0x0, map_priv_2 = 0x0, fldrv_priv = 0x0, fldrv = 0x0}
which is then handed to devm_ioremap().
David
next reply other threads:[~2009-04-16 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 15:00 David Howells [this message]
2009-04-16 15:06 ` Bug in physmap driver? Lennert Buytenhek
2009-04-16 15:09 ` David Howells
2009-04-16 15:14 ` Lennert Buytenhek
2009-04-16 15:27 ` David Howells
2009-04-16 16:23 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5680.1239894019@redhat.com \
--to=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox