From: Richard Weinberger <richard@nod.at>
To: dedekind1@gmail.com
Cc: adrian.hunter@intel.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ubifs: Fix error codes in ubifs_iget()
Date: Sun, 3 Jan 2016 14:56:25 +0100 [thread overview]
Message-ID: <56892889.6050100@nod.at> (raw)
In-Reply-To: <1451829283.13942.6.camel@gmail.com>
Am 03.01.2016 um 14:54 schrieb Artem Bityutskiy:
> On Sun, 2016-01-03 at 15:51 +0200, Artem Bityutskiy wrote:
>> On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote:
>>> We cannot use positive error codes in ERR_PTR().
>>> IS_ERR() won't catch them.
>>
>> Right, but why there is a "err = -EINVAL;" when at 'out_invalid'.
>
> Sorry Richard, I edited the sentence and did not notice it was messy.
>
> Here is what I wanted to say: right, but there is a "err = -EINVAL' at
> the end of 'out_invalid'.
Oh, you're right. I've missed this somehow.
Let's ignore this patch. :)
Thanks,
//richard
prev parent reply other threads:[~2016-01-03 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 22:11 [PATCH] ubifs: Fix error codes in ubifs_iget() Richard Weinberger
2016-01-03 13:51 ` Artem Bityutskiy
2016-01-03 13:54 ` Artem Bityutskiy
2016-01-03 13:56 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56892889.6050100@nod.at \
--to=richard@nod.at \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).