From: John Crispin <blogic@openwrt.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 0/6] MTD: lantiq: xway: various nand fixes
Date: Tue, 5 Jan 2016 08:34:04 +0100 [thread overview]
Message-ID: <568B71EC.2070309@openwrt.org> (raw)
In-Reply-To: <20160104233049.GA128501@google.com>
On 05/01/2016 00:30, Brian Norris wrote:
> On Mon, Jan 04, 2016 at 10:04:55PM +0100, John Crispin wrote:
>> This series adds various fixes for the nand driver used on Lantiq DSL SoC.
>
> Is there a good reason this driver uses plat_nand? That seems like an
> unnecessary abstraction layer. It'd be clearer to just refactor the
> driver to be a proper platform driver...
>
> Also, I see that there's no DT binding doc.
>
> Can these things be cleaned up?
>
> Brian
>
grml, i was kinda hoping this would be a no brainer. the problem is that
i don't even have the HW so refactoring / big changes are a no go or
would require me to find users with the HW first.
i'll try to get this resolved for v4.6.
John
next prev parent reply other threads:[~2016-01-05 7:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 21:04 [PATCH 0/6] MTD: lantiq: xway: various nand fixes John Crispin
2016-01-04 21:04 ` [PATCH 1/6] MTD: lantiq: xway: fix invalid operator John Crispin
2016-01-04 23:33 ` Brian Norris
2016-01-04 21:04 ` [PATCH 2/6] MTD: lantiq: xway: the latched command should be persistent John Crispin
2016-01-04 21:04 ` [PATCH 3/6] MTD: lantiq: xway: remove endless loop John Crispin
2016-01-04 23:39 ` Brian Norris
2016-01-04 21:04 ` [PATCH 4/6] MTD: lantiq: xway: add missing write_buf and read_buf to nand driver John Crispin
2016-01-04 23:35 ` Brian Norris
2016-01-04 23:45 ` Brian Norris
2016-01-04 21:05 ` [PATCH 5/6] MTD: lantiq: xway: fix nand locking John Crispin
2016-01-04 23:36 ` Brian Norris
2016-01-04 21:05 ` [PATCH 6/6] MTD: lantiq: xway: allow request line masking John Crispin
2016-01-04 23:37 ` Brian Norris
2016-01-04 23:30 ` [PATCH 0/6] MTD: lantiq: xway: various nand fixes Brian Norris
2016-01-05 7:34 ` John Crispin [this message]
2016-01-05 17:53 ` Brian Norris
2016-01-05 18:44 ` John Crispin
2016-01-05 18:55 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568B71EC.2070309@openwrt.org \
--to=blogic@openwrt.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).