From: Richard Weinberger <richard@nod.at>
To: Joe Perches <joe@perches.com>, linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] ubi: Fix early logging
Date: Thu, 25 Feb 2016 15:36:12 +0100 [thread overview]
Message-ID: <56CF115C.6010001@nod.at> (raw)
In-Reply-To: <1456406652.10763.48.camel@perches.com>
Am 25.02.2016 um 14:24 schrieb Joe Perches:
> From: Richard Weinberger <richard@nod.at>
> []
>> We must not use ubi_* log functions before the ubi_device
>> struct is initialized.
>> And while we are here, define a sane pr_fmt and add new lines to
>> existing pr_* calls.
>
> I think it'd be better to use and extend the patch I sent
> for this problem.
>
> https://patchwork.ozlabs.org/patch/587057/
>
> Add a state check of the ubi pointer in the ubi_<level>
> functions and do the right thing there.
Please send such a patch for UBI. :-)
Thanks,
//richard
next prev parent reply other threads:[~2016-02-25 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1aYvh4-0006C7-QZ@feisty.vs19.net>
2016-02-25 13:24 ` [PATCH] ubi: Fix early logging Joe Perches
2016-02-25 14:36 ` Richard Weinberger [this message]
2016-02-25 17:25 ` [PATCH] mtd: ubi: Add logging functions ubi_msg, ubi_warn and ubi_err Joe Perches
2016-03-20 21:01 ` Richard Weinberger
2016-02-22 21:47 [PATCH] ubi: Fix early logging Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CF115C.6010001@nod.at \
--to=richard@nod.at \
--cc=joe@perches.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).