Re: [PATCH] mtd: nand: jz4780: fixup, device structure assigned at probe

[Harvey Hunt <harvey.hunt@imgtec.com>]

Hi,

On 30/03/16 15:34, Boris Brezillon wrote:
> On Wed, 23 Mar 2016 21:53:27 -0400
> Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:
>
> How about adding the following message:
>
> "
> bch->dev is already assigned to &pdev->dev in the probe function.
> Remove the duplicate assignment done in jz4780_bch_get().
> "
>
> If you agree I'll add this commit message while applying (no need to
> resend).

That sounds good to me. Congrats on the maintainership btw. :-)

>
> Harvey, can I have your ack on this patch?

Acked-by: Harvey Hunt <harvey.hunt@imgtec.com>

>
> Thanks,
>
> Boris
>

Thanks,

Harvey

>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> ---
>>   drivers/mtd/nand/jz4780_bch.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/jz4780_bch.c b/drivers/mtd/nand/jz4780_bch.c
>> index 755499c..d74f4ba 100644
>> --- a/drivers/mtd/nand/jz4780_bch.c
>> +++ b/drivers/mtd/nand/jz4780_bch.c
>> @@ -287,7 +287,6 @@ static struct jz4780_bch *jz4780_bch_get(struct device_node *np)
>>   	bch = platform_get_drvdata(pdev);
>>   	clk_prepare_enable(bch->clk);
>>
>> -	bch->dev = &pdev->dev;
>>   	return bch;
>>   }
>>
>
>
>