From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qg0-x236.google.com ([2607:f8b0:400d:c04::236]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1albv2-0000l5-9Z for linux-mtd@lists.infradead.org; Thu, 31 Mar 2016 12:41:52 +0000 Received: by mail-qg0-x236.google.com with SMTP id y89so63510818qge.2 for ; Thu, 31 Mar 2016 05:41:27 -0700 (PDT) Subject: Re: [RFCv2: PATCH 1/2] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND To: Boris Brezillon References: <1458653560-2679-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1458653560-2679-2-git-send-email-jorge.ramirez-ortiz@linaro.org> <20160322145258.44945c64@bbrezillon> <56F6D727.8070001@linaro.org> <20160329095847.0ff4a400@bbrezillon> Cc: dwmw2@infradead.org, computersforpeace@gmail.com, matthias.bgg@gmail.com, robh@kernel.org, linux-mtd@lists.infradead.org, xiaolei.li@mediatek.com, daniel.thompson@linaro.org, erin.lo@mediatek.com, linux-mediatek@lists.infradead.org From: Jorge Ramirez-Ortiz Message-ID: <56FD1AF5.1000505@linaro.org> Date: Thu, 31 Mar 2016 08:41:25 -0400 MIME-Version: 1.0 In-Reply-To: <20160329095847.0ff4a400@bbrezillon> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 03/29/2016 03:58 AM, Boris Brezillon wrote: > On Sat, 26 Mar 2016 14:38:31 -0400 > Jorge Ramirez-Ortiz wrote: > >> On 03/22/2016 09:52 AM, Boris Brezillon wrote: >>>>> + compatible = "mediatek,mt2701-nfc"; >>>>> + reg = <0 0x1100d000 0 0x1000>; >>>>> + interrupts = ; >>>>> + clocks = <&pericfg CLK_PERI_NFI>, >>>>> + <&pericfg CLK_PERI_NFI_PAD>; >>>>> + clock-names = "nfi_clk", "pad_clk"; >>>>> + nand-on-flash-bbt; >>>>> + status = "disabled"; >>>>> + mediatek,ecc-controller = <&bch>; >>> Now that 2 different drivers use the same way to link the ECC engine >>> and the NAND controller we can think about defining a generic property >>> (ecc-engine ?), and provide a generic framework. >>> >>> The generic framework part is not something I'm asking right now, but I >>> think we should start using a generic property here. >>> >> we have done all the changes required for v3 except this one. >> so please let me check my understanding before going ahead: are you suggesting >> that we replace "mediatek,ecc-controller" for "ecc-engine" (even though this >> generic property doesn't exist yet)? >> >> and then afterwards, generate another patch-set set to define and document >> "ecc-engine"? > Yes, that's the idea, though the NAND controller aspect is not yet > documented in Documentation/devicetree/bindings/mtd/nand.txt, and > ecc-engine is supposed to be attached to the NAND controller node. > > I'll send a patch to further document the NAND chip, NAND controller > description concepts in this generic NAND DT bindings doc (as suggested > by Brian), and let you document this ecc-engine property. > ok I'll hold v3 -we have it ready already- until we have done this bit (hopefully it wont take long). >