Re: [PATCH 2/2] mtd: nand: Remove BUG() abuse in nand_scan_tail

Ezequiel Garcia
2016-04-04T15:26:54Z

On 4 April 2016 at 12:20, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Sat, 2 Apr 2016 15:55:24 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>
>> On Fri, 1 Apr 2016 18:29:24 -0300
>> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote:
>>
>> > There's no reason to BUG() when parameters are being
>> > validated. Drivers can get things wrong, and it's much nicer
>> > to just throw a noisy warn and fail gracefully, than calling
>> > BUG() and throwing the whole system down the drain.
>>
>> I'm fine with this change as long as all callers are checking
>> nand_scan_tail() return value.
>
> Actually, the s3c2410 driver is not checking nand_scan_tail() return
> value. Could you send a v2 addressing that?
>

Hmm, I don't see how that relates to this patch.
As far as I can see, it's two completely independent issues.

Or am I missing something here?
--
Ezequiel García, VanguardiaSur