Re: [PATCH 2/2] mtd: nand: Remove BUG() abuse in nand_scan_tail

Richard Weinberger
2016-04-01T21:51:52Z

Am 01.04.2016 um 23:29 schrieb Ezequiel Garcia:
> There's no reason to BUG() when parameters are being
> validated. Drivers can get things wrong, and it's much nicer
> to just throw a noisy warn and fail gracefully, than calling
> BUG() and throwing the whole system down the drain.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> drivers/mtd/nand/nand_base.c | 52 ++++++++++++++++++++++++++++----------------
> 1 file changed, 33 insertions(+), 19 deletions(-)

This makes sense.

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard