Re: [PATCH 2/2] mtd: nand: Remove BUG() abuse in nand_scan_tail

Ezequiel Garcia
2016-04-04T15:34:22Z

On 4 April 2016 at 12:30, Richard Weinberger <richard@nod.at> wrote:
> Am 04.04.2016 um 17:20 schrieb Boris Brezillon:
>> On Sat, 2 Apr 2016 15:55:24 +0200
>> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
>>
>>> On Fri, 1 Apr 2016 18:29:24 -0300
>>> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote:
>>>
>>>> There's no reason to BUG() when parameters are being
>>>> validated. Drivers can get things wrong, and it's much nicer
>>>> to just throw a noisy warn and fail gracefully, than calling
>>>> BUG() and throwing the whole system down the drain.
>>>
>>> I'm fine with this change as long as all callers are checking
>>> nand_scan_tail() return value.
>>
>> Actually, the s3c2410 driver is not checking nand_scan_tail() return
>> value. Could you send a v2 addressing that?
>
> And maybe add __must_check to nand_scan_tail() such that we catch issues like
> these.
>

In fact, why not adding must_check to all the functions that can fail
in the kernel?

That'll help catch even more issues ;-)
--
Ezequiel García, VanguardiaSur