Re: [PATCH 0/2] nand: Remove BUG abuse

Boris Brezillon
2016-04-02T13:56:18Z

Hi Ezequiel,

On Fri, 1 Apr 2016 18:29:22 -0300
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote:

> Hi,
>
> While using nandsim to debug an issue with an UBI image,
> I hit a BUG() when passing some crazy ID values to nandsim.
>
> I've always felt that nand_base.c is sort of abusing the
> BUG() macro, so decided to fix it.
>
> There are other BUG() uses, but they aren't in the nand_scan
> path, so I'm not touching them.

Now that you've opened the door to this rework, can you also patch other
locations where BUG() is employed? :)

Thanks,

Boris

>
> Patches apply cleanly on v4.6-rc1.
>
> Ezequiel Garcia (2):
> mtd: nand: Drop mtd.owner requirement in nand_scan
> mtd: nand: Remove BUG() abuse in nand_scan_tail
>
> drivers/mtd/nand/nand_base.c | 62 ++++++++++++++++++++++++--------------------
> 1 file changed, 34 insertions(+), 28 deletions(-)
>

--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering