public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Petr Kulhavy <petr@barix.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
	Murali Karicheri <m-karicheri2@ti.com>
Cc: linux-mtd@lists.infradead.org
Subject: DaVinci NAND: disable subpage write (28c015)
Date: Fri, 22 Apr 2016 10:20:09 +0200	[thread overview]
Message-ID: <5719DEB9.1020909@barix.com> (raw)

Hi,

this email refers to the commit: 
28c015a9daabe4ed3aeb0ccf669a3f1c2b8b81d5 on drivers/mtd/nand/davinci-nand.c.
This commit sets the NAND_NO_SUBPAGE_WRITE option for "ti,keystone-nand" 
to workaround a HW issue on the controller.

Disabling subpage write however should be made a general option because 
some NAND chips do not support subpage write at all. Subpage write is a 
feature of the NAND chip, not the NAND interface. In combination with  
"ti,davinci-nand" there is no option to disable subpage write.
In my case I'm struggling with this issue on the AM1808 with a 1Gb 
Micron NAND (MT29F1GxxABB).

My proposal would be to add a boolean property 
"ti,davinci-disable-subpage-write" or similar, which sets the 
NAND_NO_SUBPAGE_WRITE option.
I'm also wondering why no other binding is addressing this, as it is a 
general problem.

I wanted to collect your opinion before submitting a patch.

Thanks
Petr

             reply	other threads:[~2016-04-22  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22  8:20 Petr Kulhavy [this message]
2016-04-22  9:05 ` DaVinci NAND: disable subpage write (28c015) Boris Brezillon
2016-04-22 11:49   ` Petr Kulhavy
2016-04-22 12:09     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5719DEB9.1020909@barix.com \
    --to=petr@barix.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=m-karicheri2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox