linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] mtd: spi-nor: support GigaDevice gd25lq64c
@ 2016-05-06 15:37 Brian Norris
  2016-05-06 16:23 ` Marek Vasut
  0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2016-05-06 15:37 UTC (permalink / raw)
  To: linux-mtd; +Cc: Marek Vasut, Brian Norris, Ezequiel Garcia

Also note the GigaDevice JEDEC ID.

No write-protect support yet, since this flash uses a different status
register layout.

Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
v2: fixed duplicate flag

 drivers/mtd/spi-nor/spi-nor.c | 1 +
 include/linux/mtd/spi-nor.h   | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 157841dc3e99..c52e45594bfd 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -832,6 +832,7 @@ static const struct flash_info spi_nor_ids[] = {
 	/* GigaDevice */
 	{ "gd25q32", INFO(0xc84016, 0, 64 * 1024,  64, SECT_4K) },
 	{ "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) },
+	{ "gd25lq64c", INFO(0xc86017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256, SECT_4K) },
 
 	/* Intel/Numonyx -- xxxs33b */
diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
index 3c36113a88e1..7f041bd88b82 100644
--- a/include/linux/mtd/spi-nor.h
+++ b/include/linux/mtd/spi-nor.h
@@ -21,6 +21,7 @@
  * Sometimes these are the same as CFI IDs, but sometimes they aren't.
  */
 #define SNOR_MFR_ATMEL		CFI_MFR_ATMEL
+#define SNOR_MFR_GIGADEVICE	0xc8
 #define SNOR_MFR_INTEL		CFI_MFR_INTEL
 #define SNOR_MFR_MICRON		CFI_MFR_ST /* ST Micro <--> Micron */
 #define SNOR_MFR_MACRONIX	CFI_MFR_MACRONIX
-- 
2.8.0.rc3.226.g39d4020

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mtd: spi-nor: support GigaDevice gd25lq64c
  2016-05-06 15:37 [PATCH v2] mtd: spi-nor: support GigaDevice gd25lq64c Brian Norris
@ 2016-05-06 16:23 ` Marek Vasut
  2016-05-14  1:50   ` Brian Norris
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2016-05-06 16:23 UTC (permalink / raw)
  To: Brian Norris, linux-mtd; +Cc: Ezequiel Garcia

On 05/06/2016 05:37 PM, Brian Norris wrote:
> Also note the GigaDevice JEDEC ID.
> 
> No write-protect support yet, since this flash uses a different status
> register layout.
> 
> Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
> v2: fixed duplicate flag

Acked-by: Marek Vasut <marex@denx.de>

>  drivers/mtd/spi-nor/spi-nor.c | 1 +
>  include/linux/mtd/spi-nor.h   | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 157841dc3e99..c52e45594bfd 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -832,6 +832,7 @@ static const struct flash_info spi_nor_ids[] = {
>  	/* GigaDevice */
>  	{ "gd25q32", INFO(0xc84016, 0, 64 * 1024,  64, SECT_4K) },
>  	{ "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) },
> +	{ "gd25lq64c", INFO(0xc86017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  	{ "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256, SECT_4K) },
>  
>  	/* Intel/Numonyx -- xxxs33b */
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index 3c36113a88e1..7f041bd88b82 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -21,6 +21,7 @@
>   * Sometimes these are the same as CFI IDs, but sometimes they aren't.
>   */
>  #define SNOR_MFR_ATMEL		CFI_MFR_ATMEL
> +#define SNOR_MFR_GIGADEVICE	0xc8
>  #define SNOR_MFR_INTEL		CFI_MFR_INTEL
>  #define SNOR_MFR_MICRON		CFI_MFR_ST /* ST Micro <--> Micron */
>  #define SNOR_MFR_MACRONIX	CFI_MFR_MACRONIX
> 


-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mtd: spi-nor: support GigaDevice gd25lq64c
  2016-05-06 16:23 ` Marek Vasut
@ 2016-05-14  1:50   ` Brian Norris
  0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2016-05-14  1:50 UTC (permalink / raw)
  To: Marek Vasut; +Cc: linux-mtd, Ezequiel Garcia

On Fri, May 06, 2016 at 06:23:48PM +0200, Marek Vasut wrote:
> On 05/06/2016 05:37 PM, Brian Norris wrote:
> > Also note the GigaDevice JEDEC ID.
> > 
> > No write-protect support yet, since this flash uses a different status
> > register layout.
> > 
> > Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > ---
> > v2: fixed duplicate flag
> 
> Acked-by: Marek Vasut <marex@denx.de>

Forgot to note: pushed this to l2-mtd.git several days ago

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-14  1:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-06 15:37 [PATCH v2] mtd: spi-nor: support GigaDevice gd25lq64c Brian Norris
2016-05-06 16:23 ` Marek Vasut
2016-05-14  1:50   ` Brian Norris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).