From: Marek Vasut <marex@denx.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: Re: [PATCH] mtd: spi-nor: support GigaDevice gd25lq64c
Date: Fri, 06 May 2016 18:24:13 +0200 [thread overview]
Message-ID: <572CC52D.1020109@denx.de> (raw)
In-Reply-To: <20160506153724.GA88242@google.com>
On 05/06/2016 05:37 PM, Brian Norris wrote:
> On Fri, May 06, 2016 at 03:35:30AM +0200, Marek Vasut wrote:
>> On 05/06/2016 03:00 AM, Brian Norris wrote:
>>> --- a/drivers/mtd/spi-nor/spi-nor.c
>>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>>> @@ -832,6 +832,7 @@ static const struct flash_info spi_nor_ids[] = {
>>> /* GigaDevice */
>>> { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K) },
>>> { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) },
>>> + { "gd25lq64c", INFO(0xc86017, 0, 64 * 1024, 128, SECT_4K | SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>>
>> It's enough to use one SECT_4K , it will work just fine :-)
>
> Of course :) Maybe I should read my own patch next time. Will send v2
> shortly.
You can see Linus's law in action here though ;-)
> Thanks,
> Brian
>
>>> { "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256, SECT_4K) },
>>
>>
>> --
>> Best regards,
>> Marek Vasut
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2016-05-06 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 1:00 [PATCH] mtd: spi-nor: support GigaDevice gd25lq64c Brian Norris
2016-05-06 1:35 ` Marek Vasut
2016-05-06 15:37 ` Brian Norris
2016-05-06 16:24 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572CC52D.1020109@denx.de \
--to=marex@denx.de \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).