From: Jorge Ramirez <jorge.ramirez-ortiz@linaro.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: computersforpeace@gmail.com, dwmw2@infradead.org,
matthias.bgg@gmail.com, robh@kernel.org,
linux-mtd@lists.infradead.org, xiaolei.li@mediatek.com,
linux-mediatek@lists.infradead.org, erin.lo@mediatek.com,
daniel.thompson@linaro.org, blogic@openwrt.org
Subject: Re: [PATCH v4 2/2] mtd: mediatek: driver for MTK Smart Device Gen1 NAND
Date: Tue, 10 May 2016 10:45:31 -0400 [thread overview]
Message-ID: <5731F40B.801@linaro.org> (raw)
In-Reply-To: <20160510141335.442d3d7b@bbrezillon>
On 05/10/2016 08:13 AM, Boris Brezillon wrote:
>> +struct mtk_ecc {
>> >+ struct device *dev;
>> >+ void __iomem *regs;
>> >+ struct clk *clk;
>> >+
>> >+ struct completion done;
>> >+ struct semaphore sem;
> You tried to explain me why you decided to go for a semaphore instead of
> a mutex, but I don't remember. Could you explain it again?
> If that's all about being interruptible, then you can use
Just for flexibility, no other reason really.
Neither the mutex nor the semaphore are actually needed in this driver.
Not knowing how things are going to evolve in the upper layers of MTD I
didn't feel comfortable taking a lock in a function and unlocking the
mutex in a different function (which is the way this driver operates).
with that in mind I opted for a semaphore since it can always be
unlocked -if needed be- by a different thread.
next prev parent reply other threads:[~2016-05-10 14:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 16:17 [PATCH v4 0/2] MTK Smart Device Gen1 NAND Driver Jorge Ramirez-Ortiz
2016-04-29 16:17 ` [PATCH v4 1/2] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND Jorge Ramirez-Ortiz
2016-05-06 13:38 ` Boris Brezillon
2016-05-10 11:57 ` Jorge Ramirez
2016-05-10 12:22 ` Boris Brezillon
2016-04-29 16:17 ` [PATCH v4 2/2] mtd: mediatek: driver " Jorge Ramirez-Ortiz
2016-05-01 7:32 ` John Crispin
[not found] ` <1462165406.8414.196.camel@mhfsdcap03>
2016-05-02 6:13 ` John Crispin
2016-05-02 11:38 ` Jorge Ramirez
2016-05-02 17:43 ` John Crispin
2016-05-10 12:13 ` Boris Brezillon
2016-05-10 14:37 ` Jorge Ramirez
2016-05-10 14:55 ` Boris Brezillon
2016-05-10 14:45 ` Jorge Ramirez [this message]
2016-05-10 14:59 ` Boris Brezillon
2016-05-10 15:18 ` Jorge Ramirez
2016-05-10 14:50 ` Jorge Ramirez
2016-05-10 15:13 ` Boris Brezillon
2016-05-10 15:37 ` Jorge Ramirez
2016-05-10 14:53 ` Jorge Ramirez
2016-05-10 18:14 ` Jorge Ramirez
2016-05-10 18:19 ` Boris Brezillon
2016-05-10 14:53 ` Jorge Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731F40B.801@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=blogic@openwrt.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=dwmw2@infradead.org \
--cc=erin.lo@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=xiaolei.li@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).