From: Richard Weinberger <richard@nod.at>
To: Salah Triki <salah.triki@acm.org>,
dedekind1@gmail.com, adrian.hunter@intel.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc
Date: Thu, 26 May 2016 16:33:33 +0200 [thread overview]
Message-ID: <5747093D.50508@nod.at> (raw)
In-Reply-To: <1464272937-6629-1-git-send-email-salah.triki@acm.org>
Am 26.05.2016 um 16:28 schrieb Salah Triki:
> Code is more readable when using kmem_cache_zalloc instead of kmem_cache_alloc/memset.
I don't fully agree. You also have ignored my other comment on this patch.
Please note that the path you are patching is a hot path.
Thanks,
//richard
prev parent reply other threads:[~2016-05-26 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 14:28 [PATCH V2] fs: ubifs: Replace kmem_cache_alloc/memset with kmem_cache_zalloc Salah Triki
2016-05-26 14:33 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5747093D.50508@nod.at \
--to=richard@nod.at \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=salah.triki@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).