From: Stefan Roese <sr@denx.de>
To: Brian Norris <computersforpeace@gmail.com>,
kbuild test robot <fengguang.wu@intel.com>
Cc: Marek Vasut <marex@denx.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, kbuild-all@01.org,
Graham Moore <grmoore@opensource.altera.com>
Subject: Re: [mtd-next:master 30/33] drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl'
Date: Tue, 19 Jul 2016 08:03:00 +0200 [thread overview]
Message-ID: <578DC294.5090605@denx.de> (raw)
In-Reply-To: <20160718202026.GB137880@google.com>
On 18.07.2016 22:20, Brian Norris wrote:
> On Tue, Jul 19, 2016 at 03:43:17AM +0800, kbuild test robot wrote:
>> tree: git://git.infradead.org/linux-mtd-next.git master
>> head: f78921b9020c510ed222a6c2402e2aa126432415
>> commit: 140623410536905fa6ab737b625decfde6c64a72 [30/33] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller
>> config: x86_64-allmodconfig (attached as .config)
>> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
>> reproduce:
>> git checkout 140623410536905fa6ab737b625decfde6c64a72
>> # save the attached .config to linux build tree
>> make ARCH=x86_64
>>
>> All errors (new ones prefixed by >>):
>>
>> drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_read_execute':
>>>> drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration]
>> readsl(ahb_base, rxbuf, DIV_ROUND_UP(bytes_to_read, 4));
>> ^~~~~~
>> drivers/mtd/spi-nor/cadence-quadspi.c: In function 'cqspi_indirect_write_execute':
>>>> drivers/mtd/spi-nor/cadence-quadspi.c:613:3: error: implicit declaration of function 'writesl' [-Werror=implicit-function-declaration]
>> writesl(cqspi->ahb_base, txbuf, DIV_ROUND_UP(write_bytes, 4));
>> ^~~~~~~
>> cc1: some warnings being treated as errors
>
> Hmm, does x86 not define readsl()/writesl()? I can never tell what
> accessors are supposed to be "standard" across architectures.
>
> Either we need to drop the COMPILE_TEST or maybe make it (!X86 &&
> COMPILE_TEST).
iowrite32_rep() etc should work for x86 as well.
Thanks,
Stefan
next prev parent reply other threads:[~2016-07-19 6:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 19:43 [mtd-next:master 30/33] drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl' kbuild test robot
2016-07-18 20:20 ` Brian Norris
2016-07-19 6:03 ` Stefan Roese [this message]
2016-07-19 20:05 ` [PATCH] mtd: spi-nor: don't build Cadence QuadSPI on non-ARM Brian Norris
2016-07-20 1:50 ` Marek Vasut
2016-07-20 2:50 ` Brian Norris
2016-07-20 2:58 ` Marek Vasut
2016-07-20 3:25 ` Brian Norris
2016-07-20 5:59 ` Marek Vasut
2016-08-02 12:54 ` [mtd-next:master 30/33] drivers/mtd/spi-nor/cadence-quadspi.c:529:4: error: implicit declaration of function 'readsl' Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578DC294.5090605@denx.de \
--to=sr@denx.de \
--cc=computersforpeace@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=grmoore@opensource.altera.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).