Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property

From: Arseniy Krasnov <avkrasnov@sberdevices.ru>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Liang Yang <liang.yang@amlogic.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	<oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
	<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-amlogic@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property
Date: Wed, 7 Jun 2023 17:55:53 +0300	[thread overview]
Message-ID: <57ccf7ac-7d94-8a66-7a0e-abfe14f7df2c@sberdevices.ru> (raw)
In-Reply-To: <9105207b-0dfb-346f-422f-984cf3454f90@linaro.org>

On 07.06.2023 17:58, Krzysztof Kozlowski wrote:
> On 07/06/2023 16:52, Arseniy Krasnov wrote:
>>
>>
>> On 07.06.2023 12:36, Miquel Raynal wrote:
>>> Hi Arseniy,
>>>
>>> avkrasnov@sberdevices.ru wrote on Wed, 7 Jun 2023 12:04:29 +0300:
>>>
>>>> On 07.06.2023 12:08, Krzysztof Kozlowski wrote:
>>>>> On 07/06/2023 10:57, Arseniy Krasnov wrote:  
>>>>>>
>>>>>>
>>>>>> On 07.06.2023 11:53, Krzysztof Kozlowski wrote:  
>>>>>>> On 07/06/2023 10:40, Arseniy Krasnov wrote:  
>>>>>>>> Hello Miquel, 
>>>>>>>>
>>>>>>>> On 07.06.2023 10:58, Miquel Raynal wrote:
>>>>>>>>  
>>>>>>>>> Hi Arseniy,
>>>>>>>>>
>>>>>>>>> AVKrasnov@sberdevices.ru wrote on Tue, 6 Jun 2023 22:35:07 +0300:
>>>>>>>>>  
>>>>>>>>>> Add description of 'nand-rb' property. Use "Fixes" because this property
>>>>>>>>>> must be supported since the beginning. For this controller 'nand-rb' is
>>>>>>>>>> stored in the controller node (not in chip), because it has only single
>>>>>>>>>> r/b wire for all chips.  
>>>>>>>>>
>>>>>>>>> Sorry if I mislead you in the first place, but you could definitely
>>>>>>>>> have two chips and only one with RB wired. It needs to be defined in
>>>>>>>>> the chips.  
>>>>>>>>
>>>>>>>> Ok, so to clarify: is it ok, that in bindings this property will be placed in the
>>>>>>>> chip, but in driver, i'm trying to read it from the controller node (thus  in
>>>>>>>> dts file it will be also in controller node)?  
>>>
>>> The bindings and your driver internal representation are two different
>>> things. Anyway, as mentioned above, wiring the RB line to one die and
>>> not the other would be valid hardware design and would require the rb
>>> property to be in the chip node. Please perform a per-chip property read
>>> in the driver as well.
>>
>> Done, I resend both patches (bindings + driver update) as a single patchset. Your review comments
>> for driver code were also fixed.
> 
> No, please send new version, not the same. New version means with fixed
> comments and with patch changelog.

Sorry, Yes, I mean new version, here it is:
https://lore.kernel.org/linux-mtd/20230607145026.2899547-1-AVKrasnov@sberdevices.ru/

There I fixed bindings and tested it.

Thanks, Arseniy

> 
> Best regards,
> Krzysztof
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/