Re: [PATCH] mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash

From: Christian Lamparter <chunkeey@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-mtd@lists.infradead.org, "Andreas Böhler" <dev@aboehler.at>
Subject: Re: [PATCH] mtd: rawnand: add support for Toshiba TC58NVG0S3HTA00 NAND flash
Date: Mon, 6 Jun 2022 21:37:57 +0200	[thread overview]
Message-ID: <588e42b7-b28b-15c3-4f24-297c27fb4676@gmail.com> (raw)
In-Reply-To: <20220606155919.23001410@xps-13>

Hi Miquèl,

On 06/06/2022 15:59, Miquel Raynal wrote:
> christian.lamparter@isd.uni-stuttgart.de wrote on Sun, 5 Jun 2022
>> What to do in this situation? Because the patch as is is causing boot failures
>> for devices with other Kioxia/Toshiba chips. This is because they also
>> match the first four bytes but have different OOB sizes (64, instead of 128).
>>
>> Andreas has proposed the following: update the id_len to 8, this will help
>> fix the boot failures with other chips like the TC58BVG0S3HTA00, since it
>> has different values for the chip-id after the 4th byte.|
>> |
>>
>> |{"TC58NVG0S3HTA00 1G 3.3V 8-bit", { .id = {0x98, 0xf1, 0x80, 0x15} }, SZ_2K, SZ_128, SZ_128K, 0, 8, 128, NAND_ECC_INFO(8, SZ_512), },|
>>
>> ||Reverting would be an option, but if this is a counterfeit situation then
>> similar "chips" could end up in other devices and we are just unlucky
>> ones that are the first to report it :-( .
> 
> Do you have a way to probe the amount of affected devices among the
> community or perhaps by talking to the vendor?

So far no. I just heard about the (new?) AVM FritzBox 7530 revisions. These
were probably created because of shortages/price hikes? From what I can
tell (being somewhat biased there) the Fritz!Box 7530 and their variants
(there are cut-down 7520 and 7510 models) as well as rebranded models
from various ISPs in Germany.

One thing I want to point out is that Andreas mentioned in the github issue:
"I also found out that AVM matches just the four-byte ID in its GPL source code."

No idea what to think about this? Could AVM know about this
to some degree?

Is there a way to contact Toshiba/Kioxia? The e-mail address I found in
a previous patch seems to be dead :(. Anyone?

(Kioxia seems to have a B2B website about this topic:
https://personal.kioxia.com/en-emea/support/parallel-import.html

Though, I don't think this is geared towards us, the end-users...)

> Reverting seems the safest option here, not knowing how many devices
> have these damaged/counterfeit chips. If it is just a couple and only on
> Fritzboxes, as suggested in the Github issue this patch could be
> carried through OpenWRT and that would seem more future proof IMHO.

Ok, I'll move Andreas modified patch around and add it to the
ipq40xx' device-support patch heap.

> The second solution (enlarging the ID length) might work, but feels
> dirty, that's why I would go for reverting this immediately (I will
> send it through fixes), so that the support for this chip might just
> disappear "silently". Then we have another release to decide whether
> it is appropriate to use the 8-byte ID hack in the mainline kernel.
> 
> Can you please send a patch?

Yes, should be in your inbox.

Regards,
Christian

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/