Re: [PATCH] ubifs: return ENOSPC if running out of inode number

[Sheng Yong <shengyong1@huawei.com>]

On 2/7/2017 3:57 PM, Richard Weinberger wrote:
> Sheng Yong,
> 
> Am 07.02.2017 um 08:28 schrieb Sheng Yong:
>> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
>> ---
>>  fs/ubifs/dir.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
>> index 528369f..00517dc 100644
>> --- a/fs/ubifs/dir.c
>> +++ b/fs/ubifs/dir.c
>> @@ -164,7 +164,7 @@ struct inode *ubifs_new_inode(struct ubifs_info *c, struct inode *dir,
>>  			ubifs_err(c, "out of inode numbers");
>>  			make_bad_inode(inode);
>>  			iput(inode);
>> -			return ERR_PTR(-EINVAL);
>> +			return ERR_PTR(-ENOSPC);
> 
> Can you please explain *why* this has to be changed to -ENOSPC?
Hi, Richard,

This is a trivial change. I think if there is not enough inode number available,
it means the filesystem has no room for the new file. So ENOSPC may be appropriate,
and some others filesystems returns ENOSPC in such scenario :)

thanks,
Sheng
> 
> Thanks,
> //richard
> 
> .
>